Skip to content

feat(query): support comment syntax #18240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025
Merged

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Jun 24, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

COMMENT [ IF EXISTS ] ON <object_type> <object_name> IS '<string_literal>';

COMMENT [ IF EXISTS ] ON COLUMN <table_name>.<column_name> IS '<string_literal>';

In this pr support object:

  1. table
  2. column
  3. network policy
  4. password policy

Example

COMMENT IF EXISTS ON TABLE t IS 'test'
COMMENT ON COLUMN t.C1 IS 'test'
COMMENT ON network policy n1 IS 'test'
COMMENT ON password policy p1 IS 'test'

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@TCeason TCeason marked this pull request as draft June 24, 2025 10:00
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jun 24, 2025
@TCeason TCeason force-pushed the comment_syntax branch 3 times, most recently from c3e03c1 to 2c0c4d3 Compare June 25, 2025 11:20
@TCeason TCeason requested review from b41sh and sundy-li June 25, 2025 13:19
@TCeason TCeason marked this pull request as ready for review June 25, 2025 13:19
@TCeason TCeason merged commit 147ed48 into databendlabs:main Jun 26, 2025
164 of 166 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: support comment object
3 participants