Skip to content

Increase BrowserTokenAuthenticationTests timeouts #10007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025

Conversation

adamint
Copy link
Member

@adamint adamint commented Jun 23, 2025

Description

Similarly to the 'fixes' to previous playwright tests, I think we just need to increase the timeout for these tests. Increased in all tests in the class for consistency.

relevant: #9345 and #9697

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@adamint adamint requested review from radical, JamesNK and Copilot June 23, 2025 19:36
@github-actions github-actions bot added the area-integrations Issues pertaining to Aspire Integrations packages label Jun 23, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR increases the default timeout for all Playwright interactions in BrowserTokenAuthenticationTests to TestConstants.LongTimeoutTimeSpan, replacing previous default timeouts and a magic constant, and removes the [QuarantinedTest] attributes now that the tests should be stable.

  • Updated .DefaultTimeout() calls on GotoAsync, FillAsync, ClickAsync, ToBeVisibleAsync, and GetAttributeAsync to use TestConstants.LongTimeoutTimeSpan
  • Removed the pageVisibleTimeout local constant in favor of the shared timeout
  • Removed [QuarantinedTest] annotations now that tests rely on extended timeouts
Comments suppressed due to low confidence (2)

tests/Aspire.Dashboard.Tests/Integration/Playwright/BrowserTokenAuthenticationTests.cs:32

  • The [QuarantinedTest] attribute was removed. If these tests are still known to be flaky on CI, consider retaining or migrating this metadata to avoid false negatives in automated runs.
    [Fact]

tests/Aspire.Dashboard.Tests/Integration/Playwright/BrowserTokenAuthenticationTests.cs:58

  • The [QuarantinedTest] attribute was removed. Ensure these tests are reliable with the new timeouts or reapply quarantine metadata for any still-flaky scenarios.
    [Fact]

@radical
Copy link
Member

radical commented Jun 23, 2025

Could you please change Fixes https://github.com/dotnet/aspire/issues/9345 and fixes https://github.com/dotnet/aspire/issues/9697 to Attempts to fixing https://github.com/dotnet/aspire/issues/9345 and https://github.com/dotnet/aspire/issues/9697, so it does not close the issue for the quarantined test? We can close once it has ~100 successful runs on the Outerloop workflow.

@adamint adamint merged commit 9f321e4 into dotnet:main Jun 25, 2025
253 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants