[CI] Publish binaries for Aspire.Cli #9695

radical · 2025-06-04T22:57:13Z

Generate self contained single file binaries for Aspire.Cli for the following platforms:

linux-arm64
linux-x64
linux-musl-x64
osx-arm64
osx-x64
win-arm64
win-x64
win-x86

Produces archives named like aspire-cli-linux-x64-9.4.0-preview.1.25316.11.tar.gz in artifacts/packages/$(CONFIG)/Shipping.

Contributes to #9638

davidfowl · 2025-06-05T07:24:16Z

How big is it

joperezr · 2025-06-05T16:05:20Z

How big is it

~30mb

joperezr · 2025-06-05T16:08:10Z

eng/clipack/Common.projitems

@@ -0,0 +1,40 @@
+<Project>
+  <Import Sdk="Microsoft.NET.Sdk" Project="Sdk.props" />


I would have expected using the NoBuild targets sdk instead. Is there a reason why we need this one? Without it we can probably avoid having to set a target Framework.

I'm exploring that.

joperezr · 2025-06-05T16:08:49Z

eng/clipack/Common.projitems

+      <AdditionalProperties Include="RuntimeIdentifier=$(CliRuntime)" />
+      <AdditionalProperties Include="PublishSingleFile=true" />
+      <AdditionalProperties Include="SelfContained=true" />
+      <!-- <AdditionalProperties Include="GenerateDocumenationFile=false" /> -->


Is this needed?

joperezr · 2025-06-05T16:10:59Z

eng/clipack/Common.projitems

+      Text="No files were found to pack. Ensure that the project $(MSBuildProjectFullPath) has a publish target defined." />
+
+    <MakeDir Directories="$(CliPublishedArtifactsOutputDir)/$(CliRuntime)" />
+    <ZipDirectory


I know this is how we do it for the dashboard, but since this will be customer facing we should change it such that only Windows builds use .zip files, but Linux artifacts should generate .tar files instead. Most Linux distros come with utilities to extract tars, but not zips so we should avoid having this as a requirement.

Hm I can't reference System.IO.Compression and System.Formats.Tar from the inline task to make this work. I'll create a new tasks project for this, and use that.

Can we check what does dotnet sdk/installer team do here? If possible, I'd try to avoid adding a lot of complexity to the repo so let's see if there is anything we could reuse

joperezr · 2025-06-05T16:11:30Z

eng/dashboardpack/Common.projitems

undo newline :)

- This generates zip files for non-linux platforms. And `.tar.gz` for linux. - And uses Arcade blob publishing to publish the generated archives

joperezr · 2025-06-16T23:31:15Z

eng/Publishing.props

@@ -54,6 +56,11 @@
        <PublishFlatContainer>true</PublishFlatContainer>
        <RelativeBlobPath>$(_UploadPathRoot)/$(_PackageVersion)/%(Filename)%(Extension)</RelativeBlobPath>
      </ItemsToPushToBlobFeed>
+      <ItemsToPushToBlobFeed Include="@(_CliFilesToPublish)">


Did we figure out how to control the aka.ms link version so that we get a "latest" link for each of the branches we build from? For instance, we should have one that points always to latest build from main, and one that points to latest build of release/9.x.

Totally ok if you prefer to do that as a follow-up PR

Yeah, that would have to be in a follow-up.

joperezr · 2025-06-16T23:33:18Z

eng/clipack/Aspire.Cli.linux-arm64.csproj

@@ -0,0 +1,9 @@
+<Project>
+  <PropertyGroup>
+    <CliRuntime>linux-arm64</CliRuntime>


No need to block your PR for this, but we may need to add a linux-musl build as well. Thoughts @mitchdenny @DamianEdwards @davidfowl

I think that @danegsta was adding in/has added in the musl support on the DCP side too.

This is a new project though, so he wouldn't have done it for this one.

Oh, but I understand your comment now lol, yeah, because of his PR is why I made this comment 😆

Well there is no point shipping musl if the whole stack doesn't support it :)

@mitchdenny I've got this PR to add the new DCP musl build into Aspire. I'm only doing linux-musl-x64 support for now, as setting up a linux-musl-arm64 DCP build is going to be a lot more painful.

joperezr · 2025-06-16T23:36:04Z

eng/clipack/Common.projitems

+
+    <Exec
+      Condition="$(CliRuntime.StartsWith('linux-'))"
+      Command="pwsh &quot;$(_CreateTarGzScriptPath)&quot; @(_CreateTarGzArguments, ' ')"


This now means there is a new prereq in the build as I don't believe pwsh was required before, correct?

Was there nothing in the SDK that does this naitvely? Might also be worth checking with dotnet monitor CLI tool as they produce tars as part of their build so we should also see what they do. TL:DR is that if we can simplify and get to the same results without having to introduce new pre-reqs and custom scripts, it'd be better.

re:pwsh, we use that in multiple places for running tests on github actions.

re:sdk, there is a https://github.com/dotnet/sdk/blob/ad24473f7f2ae16eaee4cbd28eb6897d00df32f3/src/Tasks/sdk-tasks/TarGzFileCreateFromDirectory.cs#L8 which isn't being surfaced in a nuget. But Eric suggested https://github.com/dotnet/arcade/tree/main/src/Microsoft.DotNet.Tar which I will be trying. Still in draft :D

Another option to look into: https://github.com/dotnet/dotnet-monitor/blob/5d4c1ec2da76c832119c85cb63cb724e2c9ffa1e/eng/Publishing.props#L25-L30

dotnet-monitor does this already so perhaps we can check with folks like @wiktork on how they build their tarballs that are then published?

Excellent find! There seems to be [Microsoft.DotNet.Build.Tasks.Archives](https://github.com/dotnet/arcade/tree/d9d02d858b71562509f72ea84409853e4deffc8f/src/Microsoft.DotNet.Build.Tasks.Archives) nuget which IIUC supports this. I will try it out.

radical · 2025-06-17T05:51:33Z

WIP, not ready for review yet.

radical · 2025-06-17T05:52:41Z

Confirm that the blobs got published, and are accessible
How can we use notargets sdk with Microsoft.DotNet.Build.Tasks.Archives

radical · 2025-06-17T07:22:14Z

internal build - https://dev.azure.com/dnceng/internal/_build/results?buildId=2731897&view=results

DamianEdwards · 2025-06-17T18:15:53Z

How big is it

~30 MB

That's compressed. It's actually ~74 MB on disk. This is still WIP right? I thought I saw we got this much smaller than that?

davidfowl · 2025-06-17T18:17:20Z

We should merge this infra, aot will make it smaller.

radical · 2025-06-17T18:18:50Z

This is still WIP right?

This PR is ready to go.

joperezr · 2025-06-17T19:02:56Z

Directory.Packages.props

@@ -125,6 +125,7 @@
    <PackageVersion Include="Microsoft.DotNet.Build.Tasks.Workloads" Version="8.0.0-beta.23564.4" />
    <PackageVersion Include="Microsoft.Signed.Wix" Version="$(MicrosoftSignedWixVersion)" />
    <PackageVersion Include="Microsoft.DotNet.Build.Tasks.Installers" Version="8.0.0-beta.23564.4" />
+    <PackageVersion Include="Microsoft.DotNet.Build.Tasks.Archives" Version="8.0.0-beta.23564.4" />


NIT: no need to block you PR on this, but we should probably setup dependency flow for this.

joperezr

joperezr · 2025-06-17T19:08:38Z

eng/clipack/Common.projitems

+  <PropertyGroup>
+    <TargetFramework>$(DefaultTargetFramework)</TargetFramework>
+
+    <ArchiveName>aspire-cli-$(CliRuntime)</ArchiveName>


I really like how this file ended up looking like :)

Would be great to, in a separate PR, do the same for the dashboardpack project as that one is doing a whole bunch of complex stuff.

joperezr · 2025-06-17T19:10:12Z

eng/clipack/Common.projitems

+    <PackageReference Include="Microsoft.DotNet.Build.Tasks.Archives" />
+  </ItemGroup>
+
+  <Target Name="PublishToDisk">


NIT: don't change this now, but might be good to include in your next PR a small comment here saying that the Microsoft.DotNet.Build.Tasks.Archives targets will automatically invoke this target when the project is published so that others in the future understand how this is plugged in.

radical added the NO-MERGE label Jun 4, 2025

github-actions bot added the area-engineering-systems label Jun 4, 2025

radical force-pushed the cli-single branch from 398781e to 1505fc2 Compare June 5, 2025 05:38

radical added area-cli and removed NO-MERGE labels Jun 5, 2025

joperezr reviewed Jun 5, 2025

View reviewed changes

eng/dashboardpack/Common.projitems Outdated

</Project>

Copy link

Member

joperezr Jun 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undo newline :)

radical force-pushed the cli-single branch from 2445e82 to 0436122 Compare June 16, 2025 22:49

[CI] Generate and publish Cli as single file executable

3af06d8

- This generates zip files for non-linux platforms. And `.tar.gz` for linux. - And uses Arcade blob publishing to publish the generated archives

radical force-pushed the cli-single branch from 0436122 to 3af06d8 Compare June 16, 2025 23:15

joperezr reviewed Jun 16, 2025

View reviewed changes

Use Microsoft.DotNet.Build.Tasks.Archives to create archives

4fcb059

clipack: Use Microsoft.Build.NoTargets

42e8009

radical force-pushed the cli-single branch 2 times, most recently from 31576a5 to 42e8009 Compare June 17, 2025 06:05

radical added 4 commits June 17, 2025 02:21

add Aspire.Cli.linux-musl-x64.csproj

b89ec2c

Merge remote-tracking branch 'origin/main' into cli-single

36b6dd7

cleanup

2aaa2ee

Fix aspire.cli linux-musl build

b0e8e98

radical marked this pull request as ready for review June 17, 2025 07:32

joperezr reviewed Jun 17, 2025

View reviewed changes

joperezr approved these changes Jun 17, 2025

View reviewed changes

joperezr reviewed Jun 17, 2025

View reviewed changes

joperezr merged commit 7a1078b into dotnet:main Jun 17, 2025
252 checks passed

github-actions bot locked and limited conversation to collaborators Jul 18, 2025

		@@ -0,0 +1,40 @@
		<Project>
		<Import Sdk="Microsoft.NET.Sdk" Project="Sdk.props" />

[CI] Publish binaries for Aspire.Cli #9695

[CI] Publish binaries for Aspire.Cli #9695

Uh oh!

Conversation

radical commented Jun 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davidfowl commented Jun 5, 2025

Uh oh!

joperezr commented Jun 5, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

radical commented Jun 17, 2025

Uh oh!

radical commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

radical commented Jun 17, 2025

Uh oh!

DamianEdwards commented Jun 17, 2025

Uh oh!

davidfowl commented Jun 17, 2025

Uh oh!

radical commented Jun 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joperezr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

radical commented Jun 4, 2025 •

edited

Loading

radical commented Jun 17, 2025 •

edited

Loading