Skip to content

Fix glob pattern so it includes tests/Directory.Packages.props in update-dependencies workflow #9940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025

Conversation

joperezr
Copy link
Member

The glob pattern in the weekly update-dependencies workflow is not currently including the updates to packages in tests/Directory.Packages.props. This small change fixes that so that those would be part of the PR as well.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

…ate-dependencies workflow

The glob pattern in the weekly update-dependencies workflow is not currently including the updates to packages in tests/Directory.Packages.props. This small change fixes that so that those would be part of the PR as well.
@joperezr joperezr requested review from Copilot, danmoseley and radical and removed request for Copilot June 18, 2025 18:59
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the glob pattern in the update-dependencies workflow so that changes to tests/Directory.Packages.props are included.

  • The glob pattern in the git add command is updated to use a quoted pattern.
  • This change ensures that any Directory.Packages.props file anywhere in the repository is tracked.
Comments suppressed due to low confidence (1)

.github/workflows/update-dependencies.yml:39

  • The updated glob pattern with quotes improves clarity and ensures recursive matching. Please verify that it behaves as expected in all targeted shell environments.
          git add "**/Directory.Packages.props"

@github-actions github-actions bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Jun 18, 2025
@joperezr
Copy link
Member Author

I've tested this change in my fork and it does the right thing

@radical radical merged commit c212fd6 into main Jun 19, 2025
249 of 250 checks passed
@radical radical deleted the joperezr-patch-1 branch June 19, 2025 17:41
captainsafia pushed a commit that referenced this pull request Jun 20, 2025
…ate-dependencies workflow (#9940)

* Fix glob pattern so it includes tests/Directory.Packages.props in update-dependencies workflow

The glob pattern in the weekly update-dependencies workflow is not currently including the updates to packages in tests/Directory.Packages.props. This small change fixes that so that those would be part of the PR as well.

* Also add the root level d.p.p
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow. intentionally a different color!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants