[build] Fix versions of arcade dependencies #9941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the version string maestro instead of an older version string which is not being updated. Also drop unused references to `Microsoft.DotNet.Build.Tasks.Workloads`, and `Microsoft.DotNet.Build.Tasks.Installers`.
github-actions
bot
added
the
area-codeflow
|
internal build for validation - https://dev.azure.com/dnceng/internal/_build/results?buildId=2733092&view=results |
radical
added
the
area-engineering-systems
There was a problem hiding this comment.
Pull Request Overview
This PR updates arcade dependency versions by removing unused installer and workloads references and replacing them with the archives dependency.
- Removed references to Microsoft.DotNet.Build.Tasks.Installers and Microsoft.DotNet.Build.Tasks.Workloads
- Introduced Microsoft.DotNet.Build.Tasks.Archives in Versions.props, Version.Details.xml, and Directory.Packages.props
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eng/Versions.props | Removed installers and workloads dependencies; added Archives version |
| eng/Version.Details.xml | Removed installers and workloads dependencies and switched to Archives |
| Directory.Packages.props | Updated package versions to reference Archives via a variable |
Comments suppressed due to low confidence (2)
eng/Versions.props:42
- The new Archives dependency version still uses the numeric beta value; please confirm if this should be updated to the intended 'maestro' version string as mentioned in the PR title.
<MicrosoftDotNetBuildTasksArchivesVersion>9.0.0-beta.25302.2</MicrosoftDotNetBuildTasksArchivesVersion>
Directory.Packages.props:126
- Ensure that the variable MicrosoftDotNetBuildTasksArchivesVersion is defined with the correct 'maestro' version string if that is the intended dependency version.
<PackageVersion Include="Microsoft.DotNet.Build.Tasks.Archives" Version="$(MicrosoftDotNetBuildTasksArchivesVersion)" />
joperezr
approved these changes
Jun 19, 2025
captainsafia
pushed a commit
that referenced
this pull request
Jun 20, 2025
Use the version string maestro instead of an older version string which is not being updated. Also drop unused references to `Microsoft.DotNet.Build.Tasks.Workloads`, and `Microsoft.DotNet.Build.Tasks.Installers`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the version string maestro instead of an older version string which is not being updated.
Also drop unused references to
Microsoft.DotNet.Build.Tasks.Workloads, andMicrosoft.DotNet.Build.Tasks.Installers.