Skip to content

Reorder & don't remember Aspire version in IDE's #9961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DamianEdwards
Copy link
Member

Description

Reorders the options for Aspire version in the templates so the latest version is the first option.
Disables stickiness for the Aspire version option so that latest version is always the default selected.

Fixes #9521

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • No
  • Did you add public API?
    • No
  • Does the change make any security assumptions or guarantees?
    • No
  • Does the change require an update in our Aspire docs?
    • No

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorders the Aspire version choices so the latest version (9.4) appears first in all templates and removes persistence settings from the IDE host configuration to disable option stickiness.

  • Reorder each template.json Aspire version choice list to place 9.4 before 9.3
  • Remove persistenceScope and persistenceScopeName (and preserve visibility) in ide.host.json files
  • Ensure defaultValue remains 9.4

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

File Description
aspire-*/.template.config/template.json Swapped 9.3/9.4 choice order and kept defaultValue at 9.4
aspire-*/.template.config/ide.host.json Removed stickiness settings for AspireVersion symbols
Comments suppressed due to low confidence (4)

src/Aspire.ProjectTemplates/templates/aspire-xunit/.template.config/template.json:70

  • Consider adding a template engine or scenario test to verify that Aspire version choices are ordered with the latest version first and that defaultValue is correctly set, preventing regressions when new versions are added.
          "choice": "9.4",

src/Aspire.ProjectTemplates/templates/aspire-xunit/.template.config/ide.host.json:11

  • The isVisible property was removed for AspireVersion, so the symbol may now be hidden by default. Re-add "isVisible": true to ensure it remains visible in IDE hosts.
      "id": "AspireVersion"

src/Aspire.ProjectTemplates/templates/aspire-servicedefaults/.template.config/ide.host.json:11

  • The isVisible property was removed for AspireVersion, so the symbol may now be hidden by default. Re-add "isVisible": true to ensure it remains visible in IDE hosts.
      "id": "AspireVersion"

src/Aspire.ProjectTemplates/templates/aspire-empty/.template.config/ide.host.json:8

  • The isVisible property was removed for AspireVersion, so the symbol may now be hidden by default. Re-add "isVisible": true to ensure it remains visible in IDE hosts.
      "id": "AspireVersion"

Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left minor comments but looks good otherwise.

@DamianEdwards DamianEdwards merged commit a38e1d4 into main Jun 19, 2025
496 of 498 checks passed
@DamianEdwards DamianEdwards deleted the damianedwards/templates-default-to-latest-aspire-version branch June 19, 2025 20:29
captainsafia pushed a commit that referenced this pull request Jun 20, 2025
* Reorder & don't remember Aspire version in IDE's

Contributes to #9521

* Add back deleted properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants