-
Notifications
You must be signed in to change notification settings - Fork 648
Reorder & don't remember Aspire version in IDE's #9961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorder & don't remember Aspire version in IDE's #9961
Conversation
Contributes to #9521
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reorders the Aspire version choices so the latest version (9.4) appears first in all templates and removes persistence settings from the IDE host configuration to disable option stickiness.
- Reorder each template.json Aspire version choice list to place 9.4 before 9.3
- Remove
persistenceScope
andpersistenceScopeName
(and preserve visibility) inide.host.json
files - Ensure
defaultValue
remains 9.4
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
File | Description |
---|---|
aspire-*/.template.config/template.json | Swapped 9.3/9.4 choice order and kept defaultValue at 9.4 |
aspire-*/.template.config/ide.host.json | Removed stickiness settings for AspireVersion symbols |
Comments suppressed due to low confidence (4)
src/Aspire.ProjectTemplates/templates/aspire-xunit/.template.config/template.json:70
- Consider adding a template engine or scenario test to verify that Aspire version choices are ordered with the latest version first and that
defaultValue
is correctly set, preventing regressions when new versions are added.
"choice": "9.4",
src/Aspire.ProjectTemplates/templates/aspire-xunit/.template.config/ide.host.json:11
- The
isVisible
property was removed forAspireVersion
, so the symbol may now be hidden by default. Re-add"isVisible": true
to ensure it remains visible in IDE hosts.
"id": "AspireVersion"
src/Aspire.ProjectTemplates/templates/aspire-servicedefaults/.template.config/ide.host.json:11
- The
isVisible
property was removed forAspireVersion
, so the symbol may now be hidden by default. Re-add"isVisible": true
to ensure it remains visible in IDE hosts.
"id": "AspireVersion"
src/Aspire.ProjectTemplates/templates/aspire-empty/.template.config/ide.host.json:8
- The
isVisible
property was removed forAspireVersion
, so the symbol may now be hidden by default. Re-add"isVisible": true
to ensure it remains visible in IDE hosts.
"id": "AspireVersion"
src/Aspire.ProjectTemplates/templates/aspire-empty/.template.config/ide.host.json
Show resolved
Hide resolved
src/Aspire.ProjectTemplates/templates/aspire-servicedefaults/.template.config/ide.host.json
Show resolved
Hide resolved
src/Aspire.ProjectTemplates/templates/aspire-xunit/.template.config/ide.host.json
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left minor comments but looks good otherwise.
* Reorder & don't remember Aspire version in IDE's Contributes to #9521 * Add back deleted properties
Description
Reorders the options for Aspire version in the templates so the latest version is the first option.
Disables stickiness for the Aspire version option so that latest version is always the default selected.
Fixes #9521
Checklist