Add Azure AI Foundry support #9974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug in the FoundryLocalManager where the model is always downloaded (not doing case-insensitive checks for local models) Bug that the WaitFor isn't propogating across and the web app in playground won't start
… requires Not sure this is 100% right as the ModelInfo value isn't available until the model is downloaded, so if you don't do WaitFor Aspire will build the connection string with some null values. Also, the WaitFor, while it pauses the web app from starting, doesn't then release it to start for some reason
This should be delegated to the hosting resource to provide a valid endpoint, either generated by something like Foundry Local, or provided as expected using an endpoint from the Azure resource
…nto sebros/aifoundry
github-actions
bot
added
the
area-integrations
eerhardt
reviewed
Jun 26, 2025
eerhardt
reviewed
Jun 26, 2025
eerhardt
reviewed
Jun 26, 2025
| { | ||
| await rns.PublishUpdateAsync(resource, state => state with | ||
| { | ||
| State = KnownResourceStates.FailedToStart, |
There was a problem hiding this comment.
If this fails, does it log the reason why?
There was a problem hiding this comment.
The case when the service is not setup is handled before that, logging a message.
eerhardt
reviewed
Jun 26, 2025
eerhardt
reviewed
Jun 26, 2025
| /// Gets the connection string template for the manifest for the resource. | ||
| /// </summary> | ||
| public ReferenceExpression ConnectionStringExpression => | ||
| ReferenceExpression.Create($"Endpoint={AIFoundryApiEndpoint};EndpointAIInference={AIFoundryApiEndpoint}models"); |
There was a problem hiding this comment.
What do you think about the Endpoint being the actual endpoint bicep output from the resource?
There was a problem hiding this comment.
@sebastienros - let's follow up on this in a follow up PR.
eerhardt
approved these changes
Jun 26, 2025
davidfowl
reviewed
Jun 26, 2025
| { | ||
| ArgumentNullException.ThrowIfNull(resource); | ||
|
|
||
| return resource.Annotations.OfType<EmulatorResourceAnnotation>().Any(); |
There was a problem hiding this comment.
We can extend this in the future to check for the container annotation as well.
radical
pushed a commit
that referenced
this pull request
Jun 26, 2025
* Create Aspire.Hosting.Azure.AIFoundry integration * Remove comments * Fix managed identity authentication * Define system identity on the Foundry resource * Shared Foundry SDK * Initial implementation of Foundry Location from poc codebase * First cut at model download support Bug in the FoundryLocalManager where the model is always downloaded (not doing case-insensitive checks for local models) Bug that the WaitFor isn't propogating across and the web app in playground won't start * Rename method to proper American English * Fix connection string resolution for local deployments * Set api key for foundry local * Simplify deployment and pass Model for OpenAI * Ensuring a user message is always present * Fixing connection string to use ModelId not name, which Foundry Local requires Not sure this is 100% right as the ModelInfo value isn't available until the model is downloaded, so if you don't do WaitFor Aspire will build the connection string with some null values. Also, the WaitFor, while it pauses the web app from starting, doesn't then release it to start for some reason * Removing override on the endpoint for AI Inference SDK This should be delegated to the hosting resource to provide a valid endpoint, either generated by something like Foundry Local, or provided as expected using an endpoint from the Azure resource * Cleanup properties * wip * Refactor resources * Refactor resources * Fix connection string for OpenAI client * Update Inference clients to add /models as necessary * Add tests * Add more tests * Update readme * Update sample * Update src/Aspire.Hosting.Azure.AIFoundry/README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Clean up Aspire.Hosting.Azure.AIFoundry.csproj * Use Foundry SDK package * Disable strong name generation * Update src/Aspire.Hosting.Azure.AIFoundry/Aspire.Hosting.Azure.AIFoundry.csproj Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com> * Cleanup Extensions * Merge extensions classes * Replace Azure AI Service usage * Improve custom credential scopes * Remove unnecessary reference * Define EndpointAIInference * Fix build * More feedback * More feedback * Rename IsLocal to IsEmulator * Reuse resource instance for emulator * Fix emulator detection * Remove IResourceWithEndpoint * Update logo * Update manifests * Fix test when foundry in setup on the machine * Remove custom builder * Remove WithManifestPublishingCallback * Log when model download fails --------- Co-authored-by: Aaron Powell <me@aaron-powell.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
radical
pushed a commit
to eerhardt/aspire
that referenced
this pull request
Jun 27, 2025
* Create Aspire.Hosting.Azure.AIFoundry integration * Remove comments * Fix managed identity authentication * Define system identity on the Foundry resource * Shared Foundry SDK * Initial implementation of Foundry Location from poc codebase * First cut at model download support Bug in the FoundryLocalManager where the model is always downloaded (not doing case-insensitive checks for local models) Bug that the WaitFor isn't propogating across and the web app in playground won't start * Rename method to proper American English * Fix connection string resolution for local deployments * Set api key for foundry local * Simplify deployment and pass Model for OpenAI * Ensuring a user message is always present * Fixing connection string to use ModelId not name, which Foundry Local requires Not sure this is 100% right as the ModelInfo value isn't available until the model is downloaded, so if you don't do WaitFor Aspire will build the connection string with some null values. Also, the WaitFor, while it pauses the web app from starting, doesn't then release it to start for some reason * Removing override on the endpoint for AI Inference SDK This should be delegated to the hosting resource to provide a valid endpoint, either generated by something like Foundry Local, or provided as expected using an endpoint from the Azure resource * Cleanup properties * wip * Refactor resources * Refactor resources * Fix connection string for OpenAI client * Update Inference clients to add /models as necessary * Add tests * Add more tests * Update readme * Update sample * Update src/Aspire.Hosting.Azure.AIFoundry/README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Clean up Aspire.Hosting.Azure.AIFoundry.csproj * Use Foundry SDK package * Disable strong name generation * Update src/Aspire.Hosting.Azure.AIFoundry/Aspire.Hosting.Azure.AIFoundry.csproj Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com> * Cleanup Extensions * Merge extensions classes * Replace Azure AI Service usage * Improve custom credential scopes * Remove unnecessary reference * Define EndpointAIInference * Fix build * More feedback * More feedback * Rename IsLocal to IsEmulator * Reuse resource instance for emulator * Fix emulator detection * Remove IResourceWithEndpoint * Update logo * Update manifests * Fix test when foundry in setup on the machine * Remove custom builder * Remove WithManifestPublishingCallback * Log when model download fails --------- Co-authored-by: Aaron Powell <me@aaron-powell.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for Azure AI Foundry models and Foundry Local.
Fixes #9012 #9568
Checklist
<remarks />and<code />elements on your triple slash comments?