-
Notifications
You must be signed in to change notification settings - Fork 441
Update CentOS version -- release/8.0.1xx #19999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/8.0.1xx
Are you sure you want to change the base?
Update CentOS version -- release/8.0.1xx #19999
Conversation
@richlander I think I remember in chat that @MichaelSimons mentioned something about the runtime builds needing to change first but I couldn't find it in Teams. Currently the centos leg is failing to find the runtime version that matches. Has the runtime been updated and do we need to wait until the version in GH updates? |
Good point. I don't know the specifics. Can you log a tracking bug in runtime @MichaelSimons? |
I updated the branch because the last build was removed and I need to refresh my memory on what exactly is needed from runtime. |
Should we merge these? |
@MichaelSimons -- This is why we need better SB docs. There is significant ambiguity on this thread. It should all be clear as day in docs. It's unclear to me if the SB or runtime team has these answers. |
Yes. Min CentOS Stream versions by .NET version / branch:
|
I'm not seeing how SB docs are going to clear up anything related to this PR. The primary changes here are updating the installer's CI/PR legs. |
I likely had an incorrect notion. I thought that this repo was using CentOS Stream due to source build. Also, why are we building this repo so many times? It would be good to see this choice covered. Who is a good person to document the process and these design decisions? Lines 46 to 65 in 4b46c44
|
I would start with @marcpopMSFT. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
We never resolved what to do here. Is the next step with @jkoritzinsky? |
The next step is to figure out what version runtime is building against and use that as we can't target a latest OS than they have in their 8.0 branch as otherwise we get the missing package error like here. @jkoritzinsky ? |
Runtime builds the runtime deps package with the centos.8 RID. Runtime doesn't float the RID based on the version it targets during the build. If you can adjust the build to not force match the RID for the validation testing, that should unblock this change. |
No description provided.