Skip to content

[release/9.0.3xx][StaticWebAssets] Explicitly use invariant culture during parsing #49056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented May 19, 2025

Explicitly use invariant culture during parsing

Parsing fails on some localized installations of the SDK.

Description

We serialize the information using InvariantCulture and a specific format but then we try to deserialize that data later using the current culture, which results in the field being reported as missing and the build eventually failing.

Customer Impact

Builds will fail for customers where the current culture is not compatible with the invariant culture. The cases where we have seen this reported have been Spanish based culture (based on the language of the error message).

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

The fix is to use InvariantCulture when processing the field. In addition to that, we also included a fallback to re-compute the information in case it fails for some reason.

Verification

  • Manual (required)
  • Automated

@javiercn javiercn force-pushed the javiercn/fix-parsing branch from 6140945 to 19caf73 Compare May 19, 2025 15:49
@javiercn javiercn requested a review from MackinnonBuck May 19, 2025 15:54
@javiercn javiercn marked this pull request as ready for review May 19, 2025 15:55
@javiercn javiercn force-pushed the javiercn/fix-parsing branch from 19caf73 to fe21e8d Compare May 19, 2025 20:05
@marcpopMSFT
Copy link
Member

@javiercn @MackinnonBuck were you going to get tactics approval for this? Branch is only open a few days.

@javiercn
Copy link
Member Author

@marcpopMSFT Yes.

@javiercn javiercn force-pushed the javiercn/fix-parsing branch from fe21e8d to 42be706 Compare June 11, 2025 09:07
@lewing lewing changed the title [StaticWebAssets] Explicitly use invariant culture during parsing [release/9.0.3xx][StaticWebAssets] Explicitly use invariant culture during parsing Jun 19, 2025
@lewing lewing self-requested a review June 19, 2025 17:15
@lewing lewing merged commit 19ce9bb into release/9.0.3xx Jun 19, 2025
30 of 35 checks passed
@lewing lewing deleted the javiercn/fix-parsing branch June 19, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants