Add HelpName for --project and --launch-profile arguments of RunCommand #49418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request adds help name properties for the --project and --launch-profile options of RunCommand and updates related snapshots and localization resource files accordingly.
- Updated test snapshot to reflect new identifiers (PROJECT_PATH and LAUNCH_PROFILE).
- Modified RunCommandParser.cs to assign HelpName values from CliCommandStrings.
- Updated multiple .xlf and .resx files with new trans-unit entries for the help names.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/dotnet.Tests/CompletionTests/snapshots/zsh/DotnetCliSnapshotTests.VerifyCompletions.verified.zsh | Updated snapshot entries to reflect help name changes |
| src/Cli/dotnet/Commands/xlf/*.xlf | Added new trans-units defining LAUNCH_PROFILE and PROJECT_PATH for help names |
| src/Cli/dotnet/Commands/Run/RunCommandParser.cs | Updated Option definitions to include HelpName properties |
| src/Cli/dotnet/Commands/CliCommandStrings.resx | Added help name data entries for launch profile and project options |
MiYanni
approved these changes
Jun 16, 2025
|
Failure is an unrelated issue related to Docker Hub request limit. |
3 tasks
akoeplinger
added a commit
to akoeplinger/sdk
that referenced
this pull request
Jun 16, 2025
Follow-up to dotnet#48817 and dotnet#49418. There were only a couple commands where the option HelpName was overridden, make those explicit instead and add a test that verifies all options comply.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #48817
/cc @baronfel