Skip to content

fix copilot configuration #49497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025
Merged

Conversation

baronfel
Copy link
Member

The copilot config we just committed had a few gaps:

  • wrong name meant that it wasn't getting picked up
  • incorrect trigger made it hard to test/verify changes
  • we can skip some misused copilot cycles by pre-building the repo

@Copilot Copilot AI review requested due to automatic review settings June 19, 2025 21:55
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the Copilot workflow naming, updates triggers for easier testing, and adds a pre-build step to skip unnecessary Copilot setup cycles.

  • Removed the old .github/workflows/copilot-setup.yml to avoid conflicts.
  • Added .github/workflows/copilot-setup-steps.yml with correct name, triggers on dispatch/push/PR of the file, and read permissions.
  • Introduced an initial build step (./build.sh) to pre-restore dependencies.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/copilot-setup.yml Removed obsolete workflow so only the new config runs
.github/workflows/copilot-setup-steps.yml Added new workflow with updated triggers and pre-build step
Comments suppressed due to low confidence (1)

.github/workflows/copilot-setup-steps.yml:26

  • [nitpick] Consider using a stable version tag like actions/checkout@v4 instead of a specific commit SHA to benefit from backward-compatible updates and easier maintenance.
      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

@baronfel
Copy link
Member Author

We can actually see that this very PR matching the trigger caused the copilot steps check to trigger: https://github.com/dotnet/sdk/actions/runs/15766900602/job/44444968168?pr=49497

@baronfel
Copy link
Member Author

@KalleOlaviNiemitalo this PR might be interesting to you - you were very right to ask "does this even work" :D

@baronfel baronfel enabled auto-merge (squash) June 19, 2025 22:35
@baronfel baronfel merged commit d1954f3 into dotnet:main Jun 20, 2025
32 checks passed
@baronfel baronfel deleted the actually-fix-copilot-deps branch June 20, 2025 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants