quick, low-effort binlog upload when created by commands deriving from DotnetCommand

[baronfel]

We always forget how to get helix to upload binlogs, so what if we just did a check after each command we execute in the test framework to upload it?

[dsplaisted]

Great! It might be nice to handle file name collisions in case you have multiple tests that just specify -bl and get the default msbuild.binlog filename, but usually you're probably just interested in one test so it's not a big deal.

[baronfel]

Great! It might be nice to handle file name collisions in case you have multiple tests that just specify -bl and get the default msbuild.binlog filename, but usually you're probably just interested in one test so it's not a big deal.

I was thinking along similar lines, but at this level of our test framework we don't know if a binlog was requested. We could possibly add a fluent builder method to request a binlog that could track that data for more precise upload here. What I really expect is more per-test-case binlog name customization like I'm doing over here: f8240a4

This way, if the dev does the simple thing (adding a /bl in a test) we're more likely to do what they expect (upload that binlog) without any additional code on their end.

[baronfel]

It works! https://dev.azure.com/dnceng-public/public/_build/results?buildId=1073757&view=ms.vss-test-web.build-test-results-tab&runId=29120984&resultId=104231&paneView=dotnet-dnceng.dnceng-anon-build-release-tasks.helix-anon-test-information-tab