[dotnet-svcutil] Fully qualify XmlSchemaProvider to ensure correct resolution #5796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aExporter.cs. Refactor the ReuseIXmlSerializableType test to reference a csproj instead of pre-compiled assembly (in preparation for adding additional test type).
… from a custom namespace that requires the XmlSchemaProvider attribute.
|
@dotnet-policy-service agree company="Transmax" |
|
Note that I've extended the existing ReuseIXmlSerializableType unit test as it seemed the appropriate location. Previously that test used a pre-built binary for |
|
Being unfamiliar with the test pipelines, I'm unsure whether the failures are known race-conditions or genuine failures. Is anyone able to offer any advice or assist? Thanks. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #5792: Fully qualify the use of the
XmlSchemaProviderattribute with the correct namespace so that types which belong in non-default Xml namespaces can be correctly resolved from referenced libraries and projects. Without this fix, it resolves to the renamed XmlSchemaProvider type in the forked framework, causing the applied attribute to not be located and the type incorrect not matches as it's assumed to be in the default Xml namespace for a referenced assembly. The effect is that the type is treated as non-reusable.This is similar to @imcarolwang fix for #5638.