Skip to content

windows-11-arm runner support #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
messense opened this issue Apr 17, 2025 · 3 comments · Fixed by #145
Closed

windows-11-arm runner support #143

messense opened this issue Apr 17, 2025 · 3 comments · Fixed by #145

Comments

@messense
Copy link

It currently fails with:

Run rustup toolchain install stable --target wasm32-wasip1 --profile minimal --no-self-update
C:\a_temp\580263fa-a453-43bd-ad81-0b71ea3e688d.sh: line 1: rustup: command not found

https://github.com/PyO3/maturin/actions/runs/14514848605/job/40721477825?pr=2558
@WSH032 WSH032 mentioned this issue Apr 20, 2025
Merged
4 tasks
@pavelzw pavelzw mentioned this issue Apr 22, 2025
Merged
@jcotton42
Copy link

jcotton42 commented Apr 24, 2025 •
edited
Loading

Comparing the software list between Windows Server 2025 x64 and Windows 11 ARM64 it appears that rustup is bundled in the former, but not the latter. So the action needs to be adjusted to download when running on Windows ARM.

An issue has been opened to add rustup to the ARM image actions/partner-runner-images#77.

@jcotton42 jcotton42 mentioned this issue Apr 24, 2025
Open
@taiki-e taiki-e mentioned this issue Apr 24, 2025
Merged
joe-p added a commit to joe-p/rust-toolchain that referenced this issue Apr 29, 2025
@joe-p
Install rustup on windows (including ARM)
c18f009 
The x86 logic might be overkill since right now x86 Windows images
already have it installed, but figured might as well support it just in
case. Closed dtolnay#143
joe-p added a commit to joe-p/rust-toolchain that referenced this issue Apr 29, 2025
@joe-p
Install rustup on windows (including ARM)
dc4bcb4 
The x86 logic might be overkill since right now x86 Windows images
already have it installed, but figured might as well support it just in
case. Closes dtolnay#143
@joe-p joe-p mentioned this issue Apr 29, 2025
Merged
@joe-p
Copy link
Contributor

joe-p commented Apr 29, 2025

This specific comment includes a fix: actions/partner-runner-images#77 (comment)

I've leveraged this approach in #145

@larseggert
Copy link

Yes, that workaround works.

Note that the installed clang seems to be the amd64 version, too, so bindgen is unhappy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Install rustup on windows (including ARM) joe-p/rust-toolchain
4 participants
@larseggert @messense @jcotton42 @joe-p