Skip to content

ci(ci): update workflow #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

ci(ci): update workflow #212

merged 1 commit into from
Apr 1, 2025

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Apr 1, 2025

This PR:

  • Removes Git credentials after checkout as a security precaution by setting persist-credentials to false. They are not used after the initial checkout, and this stops them from accidentally leaking through a script; see related GitHub security post and related actions/checkout issue
  • Set check-latest to true, so that the actions/setup-node will check it is using the latest minor or hotfix Node version and use that instead of its cached version, this stops an issue like with 22.5.0 that introduced a regression and actions were still using that instead of 22.5.1
  • Updates actions to their latest major versions; only real change is that they're using Node 20 instead of Node 16

Checklist

Signed-off-by: Frazer Smith <frazer.dev@icloud.com>
Copy link

netlify bot commented Apr 1, 2025

Deploy Preview for agitated-mahavira-26f8f9 canceled.

Name Link
🔨 Latest commit 40a4451
🔍 Latest deploy log https://app.netlify.com/sites/agitated-mahavira-26f8f9/deploys/67ec071a2057370008a8b157

Copy link
Member

@galvez galvez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galvez galvez merged commit 5135c79 into dev Apr 1, 2025
6 of 7 checks passed
@Fdawgs Fdawgs deleted the Fdawgs-patch-1 branch April 2, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants