Move __future__ interpolation into interpolation.py
#4346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjward
reviewed
Jun 2, 2025
leo-collins
force-pushed
the
new-interpolate
branch
from
2e502b6 to
5d5b6e1
Compare
dham
previously approved these changes
Jun 26, 2025
pbrubeck
reviewed
Jun 26, 2025
leo-collins
force-pushed
the
new-interpolate
branch
from
5d5b6e1 to
028fc46
Compare
The `__future__.Interpolator`'s `__new__` method did not include `target_mesh.topological_dimension() == source_mesh.topological_dimension()` in the conditional. This broke the `test_submesh_interpolate_3Dcell_2Dfacet_simplex_sckelton()` inside `test_submesh_interpolate.py` because FIAT was trying to dot arrays with the incorrect shape.
`warnings.deprecated` was added in Python 3.13.
leo-collins
force-pushed
the
new-interpolate
branch
from
028fc46 to
d7b8b2f
Compare
pbrubeck
reviewed
Jul 3, 2025
| @@ -182,8 +176,7 @@ def interpolate( | |||
| to zero. Ignored if interpolating within the same mesh or onto a | |||
| :func:`.VertexOnlyMesh`. | |||
| :kwarg ad_block_tag: An optional string for tagging the resulting assemble block on the Pyadjoint tape. | |||
| :returns: a new :class:`.Function` in the space ``V`` (or ``V`` if | |||
| it was a Function). | |||
| :returns: A synbolic :class:`.Interpolate` object | |||
pbrubeck
reviewed
Jul 3, 2025
| @@ -1,14 +1,11 @@ | |||
| import firedrake.assemble as assemble | |||
| import firedrake as fd | |||
There was a problem hiding this comment.
I am not sure whether we want to import firedrake as fd within the source code. Usually we resolve circular imports with assemble by importing it inside the functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves new interpolation behaviour from
firedrake.__future__intofiredrake.interpolationand updated docs and demos.