Skip to content

Import get_external_packages from petsctools not firedrake.petsc #4381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

JHopeCollins
Copy link
Member

Avoid raising our own warnings in our own tests.

@JHopeCollins JHopeCollins requested a review from connorjward June 17, 2025 15:24
@JHopeCollins JHopeCollins self-assigned this Jun 17, 2025
Copy link
Contributor

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, missed that

@connorjward connorjward enabled auto-merge (squash) June 17, 2025 15:26
@connorjward
Copy link
Contributor

Only failing an unrelated link check

@connorjward connorjward disabled auto-merge June 24, 2025 08:59
@connorjward connorjward merged commit 7432acb into master Jun 24, 2025
8 of 14 checks passed
@connorjward connorjward deleted the JHopeCollins/petsctools-warning branch June 24, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants