Speed up caching #4383
Open
Speed up caching #4383
+243
−162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjward
force-pushed
the
connorjward/cache-fixes
branch
from
de050ee to
3951383
Compare
ksagiyam
requested changes
Jun 30, 2025
Comment on lines
+261
to
+262
| def __eq__(self, other) -> bool: | ||
| return type(other) is type(self) and hash(other) == hash(self) |
There was a problem hiding this comment.
There could be hash collisions, so we should just compare item by item.
There was a problem hiding this comment.
Fair enough. I was lazy and didn't want to write them all out for __hash__ and __eq__.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a refactor of
parallel_cacheto try and address the performance issues reported in #3983.Fixes #3983
TODOs
The main changes are:
comm_gettertoget_commandcache_factorytomake_cache.as_hexdigestevery time we do a cache lookup. I think this was the main cause of the slowdown.type(make_cache()).__class__.__name__which was unsafe and slow (?).Using the example from #3983 the performance improvement takes us (with a hot cache) from 31s to 14s, so I must be doing something right.