chore: match startManualRelease and onPushToMain release jobs #549
Conversation
| - uses: actions/checkout@v3 | ||
| with: | ||
| token: ${{ secrets.IDEE_GH_TOKEN }} | ||
| - uses: ./.github/actions/gitConfig |
There was a problem hiding this comment.
The other job doesn't use this, so I removed the call to the gitConfig as well. I don't think anything else is using it, so I could remove this section too, or keep it in just in case.
There was a problem hiding this comment.
better to be gone if it can be 👍
| @@ -9,36 +9,32 @@ jobs: | |||
| uses: salesforcecli/github-workflows/.github/workflows/unitTest.yml@main | |||
| release: | |||
| runs-on: ubuntu-latest | |||
| container: | |||
| image: node:lts | |||
There was a problem hiding this comment.
Based on some light research, I think this was our likely culprit.
| tag_name: ${{ steps.changelog.outputs.tag }} | ||
| release_name: ${{ steps.changelog.outputs.tag }} | ||
| body: ${{ steps.changelog.outputs.clean_changelog }} | ||
| - uses: actions/setup-node@v3 |
There was a problem hiding this comment.
The other job also includes the setup-node, so I added this.
.github/workflows/onPushToMain.yml
Outdated
| body: ${{ steps.changelog.outputs.clean_changelog }} | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: '16.0.x' |
There was a problem hiding this comment.
node-version-file: '.nvmrc' FTW?
There was a problem hiding this comment.
ohhhh yes, lemme do that for both
| github-token: ${{ secrets.IDEE_GH_TOKEN }} | ||
| skip-version-file: true | ||
| output-file: false | ||
| tag-prefix: "v" |
There was a problem hiding this comment.
From this section, I removed tag-prefix and fallback version (which was necessary for the first run, but isn't any longer).
| @@ -27,7 +27,6 @@ jobs: | |||
| skip-on-empty: false | |||
| output-file: false | |||
| pre-commit: ./scripts/bump-lerna-version.js | |||
| tag-prefix: '' | |||
There was a problem hiding this comment.
This is being ignored in favor of the default value ("v"), so I removed it as well.
What does this PR do?
The onPushToMain job, which creates a changelog and generates a github release, started failing recently, but the startManualRelease, which has almost the same set of steps, was still working. The two jobs are now much more closely aligned, and the onPushToMain should now be passing as well.
What issues does this PR fix or reference?
@W-12592699@
Closes forcedotcom/easywriter#138