Overlay: Add manual Java overlay annotations & discard predicates #19813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Java
DataFlow Library
C#
JS
C++
documentation
Python
Go
Ruby
QL-for-QL
Rust
kaspersv
force-pushed
the
kaspersv/overlay-java-discarding
branch
from
6f5bc41 to
8672313
Compare
github-actions
bot
removed
C#
JS
C++
documentation
Python
Go
Ruby
QL-for-QL
Rust
kaspersv
force-pushed
the
kaspersv/overlay-java-discarding
branch
from
8672313 to
db52a3c
Compare
jbj
reviewed
Jun 20, 2025
kaspersv
force-pushed
the
kaspersv/overlay-java-discarding
branch
from
db52a3c to
26896ea
Compare
kaspersv
force-pushed
the
kaspersv/overlay-java-discarding
branch
from
bdf1bdd to
3c2c871
Compare
kaspersv
changed the title
kaspersv
force-pushed
the
kaspersv/overlay-java-annotations
branch
from
052023e to
81b677a
Compare
kaspersv
force-pushed
the
kaspersv/overlay-java-discarding
branch
from
3c2c871 to
0ee6a78
Compare
|
The |
jbj
previously approved these changes
Jun 25, 2025
aschackmull
reviewed
Jun 25, 2025
kaspersv
force-pushed
the
kaspersv/overlay-java-discarding
branch
from
54589c8 to
bcadf31
Compare
aschackmull
reviewed
Jun 26, 2025
kaspersv
force-pushed
the
kaspersv/overlay-java-discarding
branch
from
bcadf31 to
a9f1540
Compare
aschackmull
reviewed
Jun 26, 2025
aschackmull
reviewed
Jun 26, 2025
kaspersv
force-pushed
the
kaspersv/overlay-java-discarding
branch
from
a9f1540 to
64f27e2
Compare
kaspersv
dismissed stale reviews from aschackmull and jbj
The base branch was changed.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -221,3 +222,16 @@ | |||
| not hasSourceLocation(l, _, _) and | |||
| locations_default(loc, f, _, _, _, _) | |||
| } | |||
|
|
|||
| overlay[local] | |||
| private predicate discardableLocation(string file, @location l) { | |||
Check warning
Code scanning / CodeQL
Dead code Warning
|
|
||
| /** Discard base locations in files fully extracted in the overlay. */ | ||
| overlay[discard_entity] | ||
| private predicate discardLocation(@location l) { |
Check warning
Code scanning / CodeQL
Dead code Warning
Comment on lines
+6
to
+10
| /** | ||
| * A local predicate that always holds for the overlay variant and | ||
| * never holds for the base variant. This is used to define local | ||
| * predicates that behave differently for the base and overlay variant. | ||
| */ |
Check warning
Code scanning / CodeQL
Predicate QLDoc style. Warning
| } | ||
|
|
||
| overlay[discard_entity] | ||
| private predicate discardLocatable(@locatable el) { |
Check warning
Code scanning / CodeQL
Dead code Warning
| } | ||
|
|
||
| overlay[discard_entity] | ||
| private predicate discardReferableLocatable(@locatable el) { |
Check warning
Code scanning / CodeQL
Dead code Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #19779, adding a few additional manual overlay annotations and defining entity discard predicates for Java.
The
overlay[local?]annotations in the experimental queries are needed to ensure that virtual dispatch (which depends indirectly onActiveExperimentalModels) becomes local. In addition to the manualoverlay[local?]annotations, the PR adds anoverlay[global]annotation inDataFlowImplCommon.qllto ensure lambda flow is global.The entity discard predicates defined in this PR are not exhaustive and additional discarding may be needed. The PR adds entity discard predicates to discard the following: