Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Make autointegrate action idempotent #34

Merged
merged 7 commits into from
Oct 3, 2020

Conversation

GMNGeoffrey
Copy link
Contributor

@GMNGeoffrey GMNGeoffrey commented Oct 2, 2020

This allows us to trigger it on other events (e.g. a cron) to update
for new LLVM commits without constantly clobbering the auto-integrate
branch.

Also switches to a personal access token (for a bot) so that there
aren't issues pushing workflow files (which I ran into while testing)
and so that the action can trigger webhooks for other automation (e.g.
builds).

I'm experiencing some intermittent failures that look like
actions/checkout#363, but those were
happening before this change as well.

Tested:
Ran on my fork:
https://github.com/GMNGeoffrey/llvm-bazel/runs/1201208655
Second run:
https://github.com/GMNGeoffrey/llvm-bazel/runs/1201226878

@GMNGeoffrey GMNGeoffrey marked this pull request as draft October 2, 2020 22:36
@GMNGeoffrey GMNGeoffrey requested review from chandlerc and tpopp October 2, 2020 22:53
@GMNGeoffrey GMNGeoffrey marked this pull request as ready for review October 2, 2020 22:53
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say I fully understand this, but seems plausible to me. =]

@GMNGeoffrey
Copy link
Contributor Author

Can't say I fully understand this, but seems plausible to me. =]

If the HEAD commit of main is already in the auto-integrate branch, then don't clobber-merge it in again 😁

@GMNGeoffrey GMNGeoffrey merged commit 5d3b98b into google:main Oct 3, 2020
@GMNGeoffrey GMNGeoffrey deleted the idempotent-auto-integrate branch January 11, 2021 20:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants