-
Notifications
You must be signed in to change notification settings - Fork 441
Add ConTextTab model #1528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add ConTextTab model #1528
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
edef2d3
Add ConTextTab model
MaxSchambach 478e81f
Update countDownloads
MaxSchambach 8049ece
Update contexttab snippets
MaxSchambach 003cb98
Merge branch 'main' into add-contexttab
MaxSchambach 18ea01b
Revert back to path_extension for download count
MaxSchambach 17a6b10
Update contexttab snippet
MaxSchambach 43696e8
Update packages/tasks/src/model-libraries.ts
Wauplin 4a6a7f1
Merge branch 'main' into add-contexttab
Wauplin e0c04c2
Update packages/tasks/src/model-libraries-snippets.ts
Wauplin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can see, these 3 snippets don't really show how to use the model in the repo. Adding snippets would be very beneficial if contexttab had a
from_pretrained
method for instance to load a pre-trained model from a repo_id. By doing so, you allow users to share their own weights in new repos which will result in personalized snippets to reuse their model. Does that make sense to you?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I understand the confusion! I've omitted the default parameters, but both
ConTextTabClassifier
andConTextTabRegressor
shown in the example use the HF hub model weights, taking acheckpoint
andcheckpoint_revision
argument pointing to the HF repo. I can add it to be more verbose if you like.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Wauplin : done ✅