Skip to content

Fixes from zizmor #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

agriyakhetarpal
Copy link
Member

Description

While repositories that build JupyterLite sites don't serve sensitive files but rather static assets over GitHub Pages/etc., they are still repositories, after all, so this PR updates the deployment workflow with https://github.com/woodruffw/zizmor.

Specifically, I ran uvx zizmor --pedantic .github/workflows/ for this, and used npx pin-github-action to pin the workflows to hashes. At the time, the use of Dependabot has been discussed in #106; however, GitHub Actions versions pinned to hashes should be useful anyway, and shouldn't affect anyone outside site builders/maintainers.

Here are the docs on the rules that were fixed:

@agriyakhetarpal
Copy link
Member Author

agriyakhetarpal commented Jun 4, 2025

Ah, I didn't realise this was marked as a draft since then; this should be ready to go in. I'll rebase and test it out now!

@agriyakhetarpal agriyakhetarpal marked this pull request as ready for review June 4, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant