Skip to content

POC: use libkpa autoscaler instead of the built-in implementation #15923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Jun 11, 2025

Fixes #

Proposed Changes

Release Note


@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 11, 2025
Copy link

knative-prow bot commented Jun 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Fedosin
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from dprotaso and skonto June 11, 2025 15:06
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

Attention: Patch coverage is 74.48980% with 25 lines in your changes missing coverage. Please review.

Project coverage is 80.93%. Comparing base (cada0f4) to head (e7c01f5).

Files with missing lines Patch % Lines
pkg/autoscaler/scaling/libkpa_autoscaler.go 73.95% 17 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15923      +/-   ##
==========================================
- Coverage   80.98%   80.93%   -0.06%     
==========================================
  Files         210      211       +1     
  Lines       16780    16876      +96     
==========================================
+ Hits        13590    13658      +68     
- Misses       2838     2856      +18     
- Partials      352      362      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Fedosin Fedosin force-pushed the libkpa branch 3 times, most recently from 8a4f011 to c4909be Compare June 11, 2025 15:21
@Fedosin Fedosin closed this Jun 11, 2025
@Fedosin Fedosin reopened this Jun 11, 2025
@Fedosin Fedosin force-pushed the libkpa branch 8 times, most recently from aec1dea to 2f4ebed Compare June 12, 2025 18:06
@Fedosin Fedosin closed this Jun 12, 2025
@Fedosin Fedosin reopened this Jun 12, 2025
@Fedosin Fedosin closed this Jun 13, 2025
@Fedosin Fedosin reopened this Jun 13, 2025
@Fedosin Fedosin force-pushed the libkpa branch 4 times, most recently from 0e191f7 to 029c234 Compare June 15, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant