Skip to content

Commit f9c4535

Browse files
committed
Make CPU PSI a Beta requirement
1 parent 4f82840 commit f9c4535

File tree

1 file changed

+5
-3
lines changed
  • keps/sig-node/5394-psi-node-conditions

1 file changed

+5
-3
lines changed

keps/sig-node/5394-psi-node-conditions/README.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,22 +115,22 @@ default threshold to be used for reporting the nodes under heavy resource pressu
115115

116116
**Note:** These actions are tentative, and will depend on different the outcome from testing and discussions with sig-node members, users, and other folks.
117117

118+
**Note:** In the initial Alpha implementation, we are not introducing node pressure condition for CPU. This is because unlike memory and IO, CPU is a compressible resource. See https://github.com/kubernetes/enhancements/issues/5062 for more details.
119+
118120
1. Introduce a new kubelet config parameter, pressure threshold, to let users specify the pressure percentage beyond which the kubelet would report the node condition to disallow workloads to be scheduled on it.
119121

120-
2. Add new node conditions corresponding to high PSI (beyond threshold levels) on CPU, Memory and IO.
122+
2. Add new node conditions corresponding to high PSI (beyond threshold levels) on Memory and IO.
121123

122124
```go
123125
// These are valid conditions of the node. Currently, we don't have enough information to decide
124126
// node condition.
125127
const (
126128
127129
// Conditions based on pressure at system level cgroup.
128-
NodeSystemCPUContentionPressure NodeConditionType = "SystemCPUContentionPressure"
129130
NodeSystemMemoryContentionPressure NodeConditionType = "SystemMemoryContentionPressure"
130131
NodeSystemDiskContentionPressure NodeConditionType = "SystemDiskContentionPressure"
131132

132133
// Conditions based on pressure at kubepods level cgroup.
133-
NodeKubepodsCPUContentionPressure NodeConditionType = "KubepodsCPUContentionPressure"
134134
NodeKubepodsMemoryContentionPressure NodeConditionType = "KubepodsMemoryContentionPressure"
135135
NodeKubepodsDiskContentionPressure NodeConditionType = "KubepodsDiskContentionPressure"
136136
)
@@ -247,6 +247,7 @@ Test plan:
247247

248248
#### Alpha
249249

250+
- Conduct experiments to decide the scope of the node condition (system v.s. kubepods v.s. node) as well as the default threshold
250251
- Enables kubelet to
251252
report node conditions based off PSI values.
252253
- Initial e2e tests completed and enabled if CRI implementation supports
@@ -255,6 +256,7 @@ it.
255256

256257
#### Beta
257258

259+
- Decide whether CPU PSI will be used for node conditions.
258260
- Feature gate is enabled by default.
259261
- Extend e2e test coverage.
260262
- Allowing time for feedback.

0 commit comments

Comments
 (0)