Skip to content

Update KEP-4876 Mutable CSINode Allocatable for Beta #5386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 18, 2025
Merged

Update KEP-4876 Mutable CSINode Allocatable for Beta #5386

merged 4 commits into from
Jun 18, 2025

Conversation

torredil
Copy link
Member

@torredil torredil commented Jun 7, 2025

  • One-line PR description: Updating milestone to beta for sig-storage KEP-4876 Mutable CSINode Allocatable.
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 7, 2025
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 7, 2025
@torredil
Copy link
Member Author

torredil commented Jun 7, 2025

cc: @msau42 @gnufied

@xing-yang
Copy link
Contributor

/assign @msau42

@deads2k
Copy link
Contributor

deads2k commented Jun 9, 2025

Reminder that the PRR needs updating for the beta release.

@torredil
Copy link
Member Author

torredil commented Jun 9, 2025

@deads2k Thank you for the review David! Updated enhancement to include the sections I missed earlier (Monitoring Requirements, Upgrade and Rollback Planning, Dependencies).

@drewhagen drewhagen mentioned this pull request Jun 11, 2025
Open
8 tasks
deads2k
deads2k reviewed Jun 11, 2025
View reviewed changes
Copy link
Contributor

@deads2k deads2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor updates needed for PRR to point admins in the right direction.

@torredil
Update Graduation Criteria section
2fd61b2 
Signed-off-by: Eddie Torres <torredil@amazon.com>
@torredil
Copy link
Member Author

Updated graduation criteria section for accuracy + included links to all required tasks.

@torredil
Update beta requirement and add testgrid
2b53d31 
Signed-off-by: Eddie Torres <torredil@amazon.com>
kannon92
kannon92 reviewed Jun 12, 2025
View reviewed changes
Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRR shadow:

LGTM!

/assign @deads2k

@deads2k
Copy link
Contributor

deads2k commented Jun 16, 2025

PRR lgtm

/approve

@torredil
Copy link
Member Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 16, 2025
msau42
msau42 reviewed Jun 16, 2025
View reviewed changes
@torredil
Update GA requirement
077c2b7 
Signed-off-by: Eddie Torres <torredil@amazon.com>
@msau42
Copy link
Member

msau42 commented Jun 18, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, msau42, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2025
@k8s-ci-robot k8s-ci-robot merged commit cc7df39 into kubernetes:master Jun 18, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied

@xing-yang xing-yang

@kannon92 kannon92

@deads2k deads2k

@msau42 msau42

@kikisdeliveryservice kikisdeliveryservice

Assignees

@deads2k deads2k

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
7 participants
@torredil @xing-yang @deads2k @msau42 @k8s-ci-robot @gnufied @kannon92