Skip to content

KEP-5394: PSI-based node conditions #5395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 19, 2025

Conversation

roycaihw
Copy link
Member

@roycaihw roycaihw commented Jun 10, 2025

/sig node
/cc @haircommander @ndixita @tiraboschi

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 10, 2025
@lmktfy
Copy link

lmktfy commented Jun 11, 2025

/retitle KEP-5394: Split exposing PSI metrics into its own KEP and add Beta requirements

@k8s-ci-robot k8s-ci-robot changed the title 5394: Split exposing PSI metrics into its own KEP and add Beta requirements KEP-5394: Split exposing PSI metrics into its own KEP and add Beta requirements Jun 11, 2025
@roycaihw roycaihw force-pushed the psi-metrics-kep branch 2 times, most recently from f9c4535 to e431356 Compare June 17, 2025 00:48
We are splitting the Phase 2 into its own KEP here, to allow the two Phases to move at different paces.
We plan to graduate Phase 1 into Beta, while Phase 2 is still being developed and stay in Alpha.
@roycaihw roycaihw changed the title KEP-5394: Split exposing PSI metrics into its own KEP and add Beta requirements KEP-5394: PSI-based node conditions Jun 17, 2025
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, non-blocking alpha, but please make sure to get it added there
/approve
the PRR section

- Impact of its outage on the feature:
- Impact of its degraded performance or high-error rates on the feature:
-->
N/A
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you do actually rely on specific versions of runc, even though k8s uses those by default, I still think it's reasonable to have them explicitly listed. Just in case when someone decided so use non-standard configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, roycaihw, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2025
@mrunalp
Copy link
Contributor

mrunalp commented Jun 19, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit cb38ce4 into kubernetes:master Jun 19, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants