-
Notifications
You must be signed in to change notification settings - Fork 1.5k
KEP-5394: PSI-based node conditions #5395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/retitle KEP-5394: Split exposing PSI metrics into its own KEP and add Beta requirements |
f9c4535
to
e431356
Compare
We are splitting the Phase 2 into its own KEP here, to allow the two Phases to move at different paces. We plan to graduate Phase 1 into Beta, while Phase 2 is still being developed and stay in Alpha.
e431356
to
4b0319b
Compare
4b0319b
to
3dd6372
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit, non-blocking alpha, but please make sure to get it added there
/approve
the PRR section
- Impact of its outage on the feature: | ||
- Impact of its degraded performance or high-error rates on the feature: | ||
--> | ||
N/A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you do actually rely on specific versions of runc, even though k8s uses those by default, I still think it's reasonable to have them explicitly listed. Just in case when someone decided so use non-standard configuration.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, roycaihw, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/sig node
/cc @haircommander @ndixita @tiraboschi