Skip to content

Github CI fix: update actions versions to @v4 #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

adamviktora
Copy link
Collaborator

@adamviktora adamviktora commented Apr 16, 2025

  • updates actions/setup-node and actions/checkout versions to v4
  • actions/setup-node@v2 is using an outdated version of actions/cache, which got shutdown on 15th April 2025, details here

@openshift-ci openshift-ci bot requested review from avivtur and vojtechszocs April 16, 2025 09:42
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Apr 16, 2025
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Apr 16, 2025
Copy link
Contributor

openshift-ci bot commented Apr 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adamviktora, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adamviktora,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@rszwajko rszwajko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamviktora looks good but please add some meaningful title/comment (i.e. Updated actions from v2 to v4 or similar) and attach a link to announcement about shutting down the deprecated actions.

@adamviktora adamviktora changed the title Github CI fix Github CI fix: update actions/setup-node and actions/checkout versions to @v4 Apr 16, 2025
@adamviktora
Copy link
Collaborator Author

/retest

1 similar comment
@upalatucci
Copy link
Member

/retest

@upalatucci
Copy link
Member

/override ci/prow/kubevirt-e2e-aws

Copy link
Contributor

openshift-ci bot commented Apr 16, 2025

@upalatucci: Overrode contexts on behalf of upalatucci: ci/prow/kubevirt-e2e-aws

In response to this:

/override ci/prow/kubevirt-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adamviktora adamviktora changed the title Github CI fix: update actions/setup-node and actions/checkout versions to @v4 Github CI fix: update actions versions to @v4 Apr 16, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 567d1e7 into kubevirt-ui:main Apr 16, 2025
10 checks passed
@upalatucci
Copy link
Member

/cherry-pick release-4.18

@upalatucci
Copy link
Member

/cherry-pick release-4.17

@openshift-cherrypick-robot
Copy link
Collaborator

@upalatucci: new pull request created: #2622

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Collaborator

@upalatucci: new pull request created: #2623

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@upalatucci
Copy link
Member

/cherry-pick release-4.16

@upalatucci
Copy link
Member

/cherry-pick release-4.15

@upalatucci
Copy link
Member

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link
Collaborator

@upalatucci: new pull request created: #2624

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Collaborator

@upalatucci: new pull request created: #2625

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Collaborator

@upalatucci: new pull request created: #2626

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants