Add missing tenantid documentid #24795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
base: main
tianzhu007
reviewed
Jun 10, 2025
| ): string | undefined { | ||
| let token: string | undefined; | ||
| if (authorization) { | ||
| const base64TokenMatch = authorization.match(/Basic (.+)/); |
There was a problem hiding this comment.
How did you get this logic? Thanks. :)
There was a problem hiding this comment.
There was a problem hiding this comment.
On service side, this file is used for token validation logic
There was a problem hiding this comment.
As I mentioned in below comment, alfred and historian have different token format. So it could break existing code.
manishgargd
reviewed
Jun 11, 2025
| ): string | undefined { | ||
| let token: string | undefined; | ||
| if (authorization) { | ||
| const base64TokenMatch = authorization.match(/Basic (.+)/); |
There was a problem hiding this comment.
In addition to "basic", it can also be "Bearer"
sonalideshpandemsft
force-pushed
the
add-tenantid-documentid-1
branch
from
966e215 to
691c7a9
Compare
sonalideshpandemsft
changed the title
znewton
approved these changes
Jun 11, 2025
server/routerlicious/packages/services-utils/src/morganLoggerMiddleware.ts
Outdated
Show resolved
Hide resolved
server/routerlicious/packages/services-utils/src/morganLoggerMiddleware.ts
Outdated
Show resolved
Hide resolved
server/routerlicious/packages/services-utils/src/morganLoggerMiddleware.ts
Outdated
Show resolved
Hide resolved
znewton
requested changes
Jun 11, 2025
server/routerlicious/packages/services-utils/src/morganLoggerMiddleware.ts
Outdated
Show resolved
Hide resolved
sonalideshpandemsft
force-pushed
the
add-tenantid-documentid-1
branch
from
24a8867 to
47ebb48
Compare
yunho-microsoft
approved these changes
Jul 3, 2025
znewton
approved these changes
Jul 3, 2025
znewton
approved these changes
Jul 3, 2025
MarioJGMsoft
pushed a commit
to MarioJGMsoft/FluidFramework
that referenced
this pull request
Jul 8, 2025
This PR ensures that tenant ID and document ID are captured and logged even in cases where the server times out or returns a 499 error. Previously, these values were missing as shown in the below query https://dataexplorer.azure.com/clusters/frspme.westus2/databases/FRS?query=H4sIAAAAAAAAA1WOQYvCQAyF7%2F6K0JOCIHsV6mVB9OIu1j8QZ1I70JnpJpmKsj9%2BOy2uekrIe9972R6rnWp3pJ9EojL7hWtDTEA9BT05PxzRd7ApAS9x%2FmEX744DeoKyhOIlpAAMFjxpE%2B2ofX9Vp%2BKfE%2BLemYnCtmayE0ChdxyDH1JHreNok1EXw5PtUJtPVLpEvo2mlY0mZURWa6WAQff2pSoZQyJ1arO5xlboqSlqkjxY5eq0gaIaPiPOuCTvkd2dwMQUdL6A8w0e%2BUt4lOZ9yvkDp%2FRrfEcBAAA%3D FRSHttpRequests | where eventTimestamp >= ago(1d) | where eventName == "HttpRequest" and method == "POST" | where service == "alfred" and environment == "production" | where pathCategory == "/documents/:tenantId" | where successful == false | where status startswith "Server" | summarize count() by tenantId, documentId, status --------- Co-authored-by: Sonali Deshpande <sonalideshpande@WIN-713HU8BVS0L.redmond.corp.microsoft.com> Co-authored-by: Sonali Deshpande <sdeshpande@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that tenant ID and document ID are captured and logged even in cases where the server times out or returns a 499 error. Previously, these values were missing as shown in the below query
https://dataexplorer.azure.com/clusters/frspme.westus2/databases/FRS?query=H4sIAAAAAAAAA1WOQYvCQAyF7%2F6K0JOCIHsV6mVB9OIu1j8QZ1I70JnpJpmKsj9%2BOy2uekrIe9972R6rnWp3pJ9EojL7hWtDTEA9BT05PxzRd7ApAS9x%2FmEX744DeoKyhOIlpAAMFjxpE%2B2ofX9Vp%2BKfE%2BLemYnCtmayE0ChdxyDH1JHreNok1EXw5PtUJtPVLpEvo2mlY0mZURWa6WAQff2pSoZQyJ1arO5xlboqSlqkjxY5eq0gaIaPiPOuCTvkd2dwMQUdL6A8w0e%2BUt4lOZ9yvkDp%2FRrfEcBAAA%3D
FRSHttpRequests
| where eventTimestamp >= ago(1d)
| where eventName == "HttpRequest" and method == "POST"
| where service == "alfred" and environment == "production"
| where pathCategory == "/documents/:tenantId"
| where successful == false
| where status startswith "Server"
| summarize count() by tenantId, documentId, status