Change to createTestLogger

[MarioJGMsoft]

Description

There is a problem in our telemetry where not all of the test results are being reflected in out portal.
This PR consists in changing the getTestLogger function to the createTestLogger function which is a necessary part for the solution.

Also updates the pipelines to use PKG_SPECIFIER instead of PKG_PATH since it's better to have it consistent throughout our pipelines.

Reviewer Guidance

Please let me know if there is something else that I should be aware of.

Fixes: AB#42164

[Copilot]

Pull Request Overview

This PR updates how the test logger is injected and used in our telemetry setup and aligns pipeline variable naming.

• Switches from getTestLogger to createTestLogger in Mocha setup hooks
• Updates Mocha config to inject via FLUID_TEST_LOGGER_PKG_SPECIFIER rather than path
• Renames pipeline variables from FLUID_TEST_LOGGER_PKG_PATH to FLUID_TEST_LOGGER_PKG_SPECIFIER

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tools/pipelines/test-service-clients.yml	Replaced FLUID_TEST_LOGGER_PKG_PATH with PKG_SPECIFIER
tools/pipelines/test-real-service.yml	Replaced FLUID_TEST_LOGGER_PKG_PATH with PKG_SPECIFIER
tools/pipelines/test-perf-benchmarks.yml	Replaced FLUID_TEST_LOGGER_PKG_PATH with PKG_SPECIFIER
packages/test/mocha-test-setup/src/mochaHooks.ts	Switched to async hooks and dynamic createTestLogger import
packages/test/mocha-test-setup/mocharc-common.cjs	Added logic to inject specifier-based module before setup

Comments suppressed due to low confidence (1)

tools/pipelines/test-service-clients.yml:54

• [nitpick] This environment variable declaration is repeated across multiple pipeline files; consider extracting it into a shared template or YAML anchor to reduce duplication.

        FLUID_TEST_LOGGER_PKG_SPECIFIER: '@ff-internal/aria-logger' # Contains createTestLogger impl to inject

[github-actions]

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output

> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  213391 links
    1455 destination URLs
    1686 URLs ignored
       0 warnings
       0 errors

[alexvy86]

Last few comments. I'm particularly interested in knowing what happens when you run the e2e tests locally providing an invalid package specifier (e.g. a package name that doesn't exist). It should throw the error you wrote (after applying the suggestion below).

[alexvy86]

LGTM! 🚀