fix(check:policy): Use relative paths in package.json repository field #24887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the repository.directory field in generated package.json files by switching from absolute to relative paths.
- Updated the
resolverfunction to accept the repository root (gitRoot) - Changed
relativePkgDircomputation to usepath.relativeagainstgitRoot
Comments suppressed due to low confidence (1)
build-tools/packages/build-cli/src/library/repoPolicyCheck/npmPackages.ts:841
- Add or update unit tests to cover this new relative path resolution logic, including edge cases like files at the repo root and nested directories.
const relativePkgDir = path.dirname(path.relative(gitRoot, file)).replace(/\\/g, "/");
| return undefined; | ||
| }, | ||
| resolver: (file: string): { resolved: boolean } => { | ||
| resolver: (file: string, gitRoot: string): { resolved: boolean } => { |
There was a problem hiding this comment.
The resolver signature was changed to include gitRoot, but the Handler interface and any call sites need to be updated accordingly to prevent type mismatches or runtime errors.
Copilot uses AI. Check for mistakes.
scottn12
approved these changes
Jun 23, 2025
alexvy86
approved these changes
Jun 23, 2025
MarioJGMsoft
pushed a commit
to MarioJGMsoft/FluidFramework
that referenced
this pull request
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resolver for the package.json repository.directory field was using absolute paths instead of relative ones. That is now fixed.