Fix PREfast Warning C26495, and excluded the generated file path for prefast task #5556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
alexlamtest
reviewed
Jul 9, 2025
| m_nSegmentOverride = 0; | ||
| m_lScratchExtra = 0; | ||
| m_pbScratchTarget = nullptr; | ||
| memset(m_rbScratchDst, 0, sizeof(m_rbScratchDst)); |
There was a problem hiding this comment.
Nonblocking nit: it is unclear why introducing the use of memset() here. This file already uses ZeroMemory(), does it make sense to keep using ZeroMemory()?
| @@ -84,7 +84,7 @@ steps: | |||
| msBuildCommandline: 'msbuild.exe /restore /nologo /nr:false /p:configuration=Release /p:platform=x64 $(Build.SourcesDirectory)\WindowsAppRuntime.sln' | |||
| # Generally speaking, we leave it to the external repos to scan the bits in their packages. | |||
| excludedPaths: | | |||
| $(Build.SourcesDirectory)\packages | |||
| C:\__t\uCRT\#$(Build.SourcesDirectory)\obj\$(buildConfiguration)\$(buildPlatform)#$(Build.SourcesDirectory)\packages | |||
There was a problem hiding this comment.
Can you please try replacing "__t" with "$(Agent.ToolsDirectory)" to see if it still works?
We generally prefer using more readable/meaningful variable names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Some of the warnings need initialize variables in this repo.
2.Warnings under "Generated Files/winrt" folder or under STL headers folder, prefast tasks don't need to scan them.
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.