Fix: Normalize Unicode in file paths to handle macOS screenshot filenames (ENOENT) #2112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olaservo
added
server-filesystem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR addresses issue Fixes #1970: macOS screenshot files with non-breaking spaces and special Unicode characters are now properly recognized by all MCP filesystem operations.
Key changes:
Adds a new utility (unicodeNormalize.ts) to normalize filenames (NFC, replace U+00A0 and other Unicode spaces/punctuation).
Applies normalization in all core file operations (move, read, write, edit, create, etc.).
Improves error messages for ENOENT if a Unicode issue is suspected.
Updates documentation with a dedicated Unicode filename handling section.
Adds tests for normalization edge cases.
Commit message: fix(filesystem): normalize Unicode in file paths for macOS screenshot compatibility
Introduce normalizeUnicodePath utility for NFC normalization and Unicode space/punctuation replacement.
Apply normalization in all relevant file system handlers.
Enhance ENOENT error messages to help users identify Unicode filename issues.
Document Unicode quirks in README.
Add tests for normalization logic.