Skip to content

ci: remove git credentials after checkout #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

Conversation

Fdawgs
Copy link
Contributor

@Fdawgs Fdawgs commented Apr 22, 2025

This PR removes Git credentials after checkout as a security precaution by setting persist-credentials to false. They are not used after the initial checkout, and this stops them from accidentally leaking through a script; see related GitHub security post and related actions/checkout issue.

@RafaelGSS RafaelGSS merged commit 081635c into nodejs:main Apr 30, 2025
7 checks passed
@Fdawgs Fdawgs deleted the ci/creds branch May 1, 2025 05:35
zoidszintuition added a commit to zoidszintuition/security-wg that referenced this pull request May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants