-
Notifications
You must be signed in to change notification settings - Fork 370
feat(CC-batch-1): added batch 1 #11827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview: https://patternfly-react-pr-11827.surge.sh A11y report: https://patternfly-react-pr-11827-a11y.surge.sh |
dbf3c61
to
9f6488f
Compare
nicolethoen
requested changes
May 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would each component benefit from an added comment linking directly to the component docs on patternfly.org? I think that'd be helpful.
packages/code-connect/components/Accordion/AccordionToggle.figma.tsx
Outdated
Show resolved
Hide resolved
packages/code-connect/components/ClipboardCopy/ClipboardCopyBasic.figma.tsx
Show resolved
Hide resolved
kmcfaul
reviewed
May 29, 2025
3 tasks
kmcfaul
approved these changes
Jun 4, 2025
nicolethoen
approved these changes
Jun 6, 2025
nicolethoen
reviewed
Jun 11, 2025
packages/code-connect/components/AboutModal/AboutModal.figma.tsx
Outdated
Show resolved
Hide resolved
evwilkin
reviewed
Jun 23, 2025
87e29cb
to
b8ea3bf
Compare
kmcfaul
approved these changes
Jul 25, 2025
mattnolting
added a commit
to mattnolting/patternfly-react
that referenced
this pull request
Jul 25, 2025
* feat(CC-batch-1): prepared batch 1 * feat(CC-batch-1): moved CC out of react-core * feat(CC-batch-1): updated props * feat(CC-batch-1): updated props and comments * feat(CC-batch-1): updated component link comments * feat(CC-batch-1): minor formatting updates * feat(CC-batch-1): verification complete * feat(CC-batch-1): review-athon round 1 followup * feat(CC-batch-2): added accordion toggle note * feat(CC-batch-1): review-athon round 1 followup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #11624
Included components:
Component tracker
Figma preview
Resources: