feat(CC-batch-8): added batch 8 #11870
Open
+399
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-11870.surge.sh A11y report: https://patternfly-react-pr-11870-a11y.surge.sh |
evwilkin
reviewed
Jun 26, 2025
| props: { | ||
| // boolean | ||
| isInputVisible: figma.boolean('Value input'), | ||
| minmaxValues: figma.boolean('Min/max values'), |
There was a problem hiding this comment.
I don't see "Min/max values" in Figma. This maps below to the showBoundaries prop, the logic makes sense but maybe this has been removed from Figma and should be removed here as well?
evwilkin
reviewed
Jun 26, 2025
evwilkin
reviewed
Jun 26, 2025
evwilkin
reviewed
Jun 26, 2025
evwilkin
reviewed
Jun 26, 2025
Co-authored-by: Evan <evan.wilkinson@gmail.com>
Co-authored-by: Evan <evan.wilkinson@gmail.com>
Co-authored-by: Evan <evan.wilkinson@gmail.com>
Co-authored-by: Evan <evan.wilkinson@gmail.com>
mattnolting
force-pushed
the
feat-CC-batch-8
branch
from
9dea0f2 to
c2efe09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #11624
Included components:
Component tracker
Figma preview
Resources: