fix: simplify scripts by adding devDependencies #262
Conversation
🦋 Changeset detectedLatest commit: 9be555a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Unrelated to your change, but the pipeline seems to have completely stop working.
Found a issue regarding the matter, fix should be as easy as actions/setup-node#1275 (comment).
Could you make that change?
jorrit
force-pushed
the
fixdevelop
branch
2 times, most recently
from
17ed4fc to
76986d6
Compare
|
It seems that my change does not work on the build server. It seems weird to me that |
Probably because core has |
jorrit
force-pushed
the
fixdevelop
branch
3 times, most recently
from
ba0f544 to
548b603
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #262 +/- ##
=======================================
Coverage 42.50% 42.50%
=======================================
Files 2 2
Lines 640 640
Branches 154 156 +2
=======================================
Hits 272 272
Misses 293 293
Partials 75 75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
You were absolutely right. I moved a bunch of other script dependencies to devDependencies so the executables can be referenced by name instead of by path. |
jorrit
changed the title
What does it do?
Makes
yarn developin the root directory work (on my machine) by using the same commands inwebtools-addon-sitemapas in the other packages.Why is it needed?
To develop this plugin.
How to test it?
Run
yarn develop.Before:
After: