feat(pb): get multi-actors working e2e, add resources for builds #2465

MasterPtato · 2025-05-21T01:38:18Z

Changes

MasterPtato · 2025-05-21T01:38:36Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

cloudflare-workers-and-pages · 2025-05-21T01:39:52Z

Deploying rivet with Cloudflare Pages

Latest commit:	`5a56a42`
Status:	🚫 Build failed.

View logs

greptile-apps

PR Summary

This PR implements multi-actor support and resource management for builds, with significant changes across the codebase to support allocation types and optional resource specifications.

Added new BuildsAllocation types in SDKs to support both single and multi-slot allocations, with proper serialization and validation
Made actor resources optional by changing resources field from required to optional in ActorsActor type, affecting database schema and API endpoints
Renamed build-related types for better consistency (e.g., BuildsBuildKind -> BuildsKind, BuildsBuildCompression -> BuildsCompression)
Fixed critical bug in managerClient.ts where signal_actor handler incorrectly references packet.start_actor instead of packet.signal_actor
Added proper resource validation in pegboard service based on build allocation type (None, Single, Multi) with CPU millicores and memory MiB specifications

_{139 file(s) reviewed, 44 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-05-21T01:39:48Z

examples/system-test-actor/src/httpServer.ts

@@ -41,8 +37,7 @@ export function createAndStartServer(
 		const query = c.req.query("code");
 		const exitCode = query ? Number(query) : 0;

-		if (typeof Deno != "undefined") Deno.exit(exitCode);
-		else process.exit(exitCode);
+		process.exit(exitCode);

 		return c.text("unreachable");


style: unreachable code after process.exit() should be removed

greptile-apps · 2025-05-21T01:39:54Z

examples/system-test-actor/src/main.ts

+import { createAndStartUdpServer } from "./udpServer.js";
+import { connectToManager } from "./managerClient.js";
+
+let injectWebSocket: any;


style: avoid using 'any' type - should define proper type from @hono/node-ws

greptile-apps · 2025-05-21T01:39:54Z

examples/system-test-actor/src/main.ts

+const server = serve({ fetch: app.fetch, port });
+injectWebSocket(server);


style: server instance should be handled for graceful shutdown (e.g., process.on('SIGTERM'))

greptile-apps · 2025-05-21T01:39:55Z

examples/system-test-actor/src/main.ts

+
+createAndStartUdpServer();
+
+if (process.env.MULTI) {


style: use explicit boolean check for environment variable

Suggested change

if (process.env.MULTI) {

if (process.env.MULTI === 'true') {

greptile-apps · 2025-05-21T01:40:27Z

examples/system-test-actor/src/udpServer.ts

+		});
+
+
+		const port2 = Number.parseInt(portEnv);


style: port validation should happen before socket creation to avoid creating resources that may need cleanup

greptile-apps · 2025-05-21T01:59:20Z

sdks/api/runtime/rust/src/models/builds_build.rs

    #[serde(rename = "content_length")]
    pub content_length: i64,


logic: content_length is typed as i64 but documented as 'Unsigned 64 bit integer' - this could allow negative values when it shouldn't

Suggested change

#[serde(rename = "content_length")]

pub content_length: i64,

#[serde(rename = "content_length")]

pub content_length: u64,

greptile-apps · 2025-05-21T02:00:03Z

sdks/api/runtime/rust/src/models/builds_resources.rs

+
+
+
+#[derive(Clone, Debug, PartialEq, Default, Serialize, Deserialize)]


style: Missing explicit serde crate import. While it may work due to prelude, explicit imports improve code clarity

greptile-apps · 2025-05-21T02:00:45Z

sdks/api/runtime/typescript/src/api/resources/builds/resources/common/types/Allocation.ts

+export interface Allocation {
+    single?: Rivet.builds.AllocationSingle;
+    multi?: Rivet.builds.AllocationMulti;
+}


logic: Both fields being optional (marked with ?) means an Allocation could potentially have neither single nor multi set. Consider if this is the intended behavior or if at least one should be required.

greptile-apps · 2025-05-21T02:03:30Z

sdks/api/runtime/typescript/src/serialization/resources/builds/resources/common/types/Kind.ts

+);
+
+export declare namespace Kind {
+    export type Raw = "docker_image" | "oci_bundle" | "javascript";


style: Raw type should be marked as readonly to prevent accidental modification of valid enum values

greptile-apps · 2025-05-21T02:04:01Z

sdks/api/runtime/typescript/src/serialization/resources/builds/types/BuildCompression.ts

logic: Removing this file will break build compression type serialization unless this functionality has been moved elsewhere. Need to verify that equivalent functionality exists in another location before proceeding with deletion.

cloudflare-workers-and-pages · 2025-05-27T02:02:10Z

Deploying rivet-studio with Cloudflare Pages

Latest commit:	`5a56a42`
Status:	🚫 Build failed.

View logs

cloudflare-workers-and-pages · 2025-05-27T02:11:19Z

Deploying rivet-hub with Cloudflare Pages

Latest commit:	`5a56a42`
Status:	🚫 Build failed.

View logs

MasterPtato requested a review from NathanFlurry May 21, 2025 01:38

This was referenced May 21, 2025

feat(pb): add runner logs #2447

Open

fix(pegboard): fix netns path bug #2431

Closed

fix: swap status monitor dns resolver with native resolver #2432

Closed

feat: add runners to pb protocol #2433

Open

greptile-apps bot reviewed May 21, 2025

View reviewed changes

This was referenced May 22, 2025

feat: implement new actor ids #2467

Open

fix(pb): get new actor ids working e2e #2471

Open

MasterPtato force-pushed the 05-16-feat_pb_add_runner_logs branch from 9b820e0 to ed03e29 Compare May 27, 2025 02:02

MasterPtato force-pushed the 05-21-feat_pb_get_multi-actors_working_e2e_add_resources_for_builds branch from d94da15 to 14ec025 Compare May 27, 2025 02:02

MasterPtato force-pushed the 05-16-feat_pb_add_runner_logs branch from ed03e29 to 869e278 Compare June 17, 2025 18:39

MasterPtato force-pushed the 05-21-feat_pb_get_multi-actors_working_e2e_add_resources_for_builds branch from 14ec025 to 6a71c38 Compare June 17, 2025 18:39

This was referenced Jun 17, 2025

fix: add cache to server list queries #2620

Closed

fix: make service discovery use a single client #2621

Closed

fix: figure out actor log shipping #2622

Open

fix: get new actors working on docker compose #2623

Open

MasterPtato force-pushed the 05-21-feat_pb_get_multi-actors_working_e2e_add_resources_for_builds branch from 6a71c38 to 8eb564a Compare June 20, 2025 19:09

MasterPtato force-pushed the 05-16-feat_pb_add_runner_logs branch from 869e278 to 3d46e7d Compare June 20, 2025 19:09

MasterPtato force-pushed the 05-21-feat_pb_get_multi-actors_working_e2e_add_resources_for_builds branch from 8eb564a to f1efbe3 Compare June 20, 2025 19:52

MasterPtato force-pushed the 05-16-feat_pb_add_runner_logs branch from 3d46e7d to 3917cbb Compare June 20, 2025 19:52

MasterPtato force-pushed the 05-21-feat_pb_get_multi-actors_working_e2e_add_resources_for_builds branch from f1efbe3 to bad492a Compare June 20, 2025 19:54

MasterPtato force-pushed the 05-16-feat_pb_add_runner_logs branch from 3917cbb to 55980f3 Compare June 20, 2025 19:54

NathanFlurry force-pushed the 05-21-feat_pb_get_multi-actors_working_e2e_add_resources_for_builds branch from bad492a to 952db69 Compare June 20, 2025 19:57

NathanFlurry force-pushed the 05-16-feat_pb_add_runner_logs branch from 55980f3 to 5677a5b Compare June 20, 2025 19:57

feat(pb): get multi-actors working e2e, add resources for builds

5a56a42

NathanFlurry force-pushed the 05-16-feat_pb_add_runner_logs branch from 5677a5b to bbadc72 Compare June 20, 2025 20:34

NathanFlurry force-pushed the 05-21-feat_pb_get_multi-actors_working_e2e_add_resources_for_builds branch from 952db69 to 5a56a42 Compare June 20, 2025 20:34

This was referenced Jun 20, 2025

fix: add udp ports to docker compose #2635

Open

feat: get multi actors working e2e on docker compose #2637

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(pb): get multi-actors working e2e, add resources for builds #2465

feat(pb): get multi-actors working e2e, add resources for builds #2465

Uh oh!

MasterPtato commented May 21, 2025

Uh oh!

MasterPtato commented May 21, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages bot commented May 21, 2025 •

edited

Loading

Uh oh!

greptile-apps bot left a comment

Uh oh!

greptile-apps bot May 21, 2025

Uh oh!

greptile-apps bot May 21, 2025

Uh oh!

greptile-apps bot May 21, 2025

Uh oh!

greptile-apps bot May 21, 2025

Uh oh!

greptile-apps bot May 21, 2025

Uh oh!

greptile-apps bot May 21, 2025

Uh oh!

greptile-apps bot May 21, 2025

Uh oh!

greptile-apps bot May 21, 2025

Uh oh!

greptile-apps bot May 21, 2025

Uh oh!

greptile-apps bot May 21, 2025

Uh oh!

cloudflare-workers-and-pages bot commented May 27, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages bot commented May 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

		const server = serve({ fetch: app.fetch, port });
		injectWebSocket(server);




		#[derive(Clone, Debug, PartialEq, Default, Serialize, Deserialize)]


		createAndStartUdpServer();

		if (process.env.MULTI) {

feat(pb): get multi-actors working e2e, add resources for builds #2465

Are you sure you want to change the base?

feat(pb): get multi-actors working e2e, add resources for builds #2465

Uh oh!

Conversation

MasterPtato commented May 21, 2025

Changes

Uh oh!

MasterPtato commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

cloudflare-workers-and-pages bot commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet with Cloudflare Pages

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

greptile-apps bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot May 21, 2025

Choose a reason for hiding this comment

Uh oh!

cloudflare-workers-and-pages bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet-studio with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rivet-hub with Cloudflare Pages

Uh oh!

Uh oh!

MasterPtato commented May 21, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented May 21, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented May 27, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented May 27, 2025 •

edited

Loading