-
Notifications
You must be signed in to change notification settings - Fork 106
fix(toolchain): fix compat with deploying using podman #2571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
35283d8
to
8634a7b
Compare
Deploying rivet with
|
Latest commit: |
184d5a4
|
Status: | ✅ Deploy successful! |
Preview URL: | https://e68992d5.rivet.pages.dev |
Branch Preview URL: | https://06-08-fix-toolchain-fix-comp.rivet.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Improves Docker archive handling compatibility for Podman and other container runtimes in the Rivet toolchain.
- Added
#[serde(default)]
for DockerImageConfig's user field inpackages/toolchain/toolchain/src/util/docker/archive.rs
to handle images without user specifications - Modified path prefix stripping logic to handle non-absolute paths from different container runtimes
- Maintains existing security restrictions around root user access while improving container runtime compatibility
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
1a2c0b8
to
ec1d934
Compare
8634a7b
to
94015fb
Compare
Deploying rivet-hub with
|
Latest commit: |
184d5a4
|
Status: | ✅ Deploy successful! |
Preview URL: | https://236cd13d.rivet-hub-7jb.pages.dev |
Branch Preview URL: | https://06-08-fix-toolchain-fix-comp.rivet-hub-7jb.pages.dev |
94015fb
to
9b68bee
Compare
f224e36
to
97a6df1
Compare
adf061a
to
839cbb6
Compare
Claude finished @NathanFlurry's task —— View job PR Review Complete ✅Todo List:
Code Review Summary✅ Overall Assessment: APPROVEDThis is a well-targeted compatibility fix that addresses real-world issues with Podman and other container runtimes. The changes are minimal, focused, and maintain existing security guarantees. Code Quality & Best Practices
Bug Fixes & Compatibility
Security Analysis
Performance Considerations
Test Coverage
Technical DetailsLocation: Changes made:
Impact:
Potential Improvements
|
Claude finished @NathanFlurry's task —— View job Code Review Complete ✅Reviewing this PR for:
Code Review Summary✅ Overall Assessment: APPROVEDThis is a well-targeted compatibility fix that addresses real-world issues with Podman and other container runtimes. The changes are minimal, focused, and maintain existing security guarantees. Code Quality & Best Practices
Bug Fixes & Compatibility
Security Analysis
Performance Considerations
Test Coverage
Technical DetailsLocation: Changes made:
Impact:
Potential Improvements
|
839cbb6
to
609928e
Compare
97a6df1
to
184d5a4
Compare
Claude finished @NathanFlurry's task —— View job Code Review Complete ✅Reviewing this PR for:
Code Review Summary✅ Overall Assessment: APPROVEDThis is a well-targeted compatibility fix that addresses real-world issues with Podman and other container runtimes. The changes are minimal, focused, and maintain existing security guarantees. Code Quality & Best Practices
Bug Fixes & Compatibility
Security Analysis
Performance Considerations
Test Coverage
Technical DetailsLocation: Changes made:
Impact:
Potential Improvements
|
184d5a4
to
97a6df1
Compare
609928e
to
839cbb6
Compare
Claude finished @NathanFlurry's task —— View job Code Review Complete ✅Reviewing this PR for:
Code Review Summary✅ Overall Assessment: APPROVEDThis is a well-targeted compatibility fix that addresses real-world issues with Podman and other container runtimes. The changes are minimal, focused, and maintain existing security guarantees. Code Quality & Best Practices
Bug Fixes & Compatibility
Security Analysis
Performance Considerations
Test Coverage
Technical DetailsLocation: Changes made:
Impact:
Potential Improvements
|
Claude finished @NathanFlurry's task —— View job PR Review Complete ✅Reviewing this PR for:
Code Review Summary✅ Overall Assessment: APPROVEDThis is a well-targeted compatibility fix that addresses real-world issues with Podman and other container runtimes. The changes are minimal, focused, and maintain existing security guarantees. Code Quality & Best Practices
Bug Fixes & Compatibility
Security Analysis
Performance Considerations
Test Coverage
Technical DetailsLocation: Changes made:
Impact:
Potential Improvements
|
Merge activity
|
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved handling of user field defaults when processing Docker image configurations. * Enhanced robustness when processing file paths and hard links in TAR archives, reducing potential errors with path prefix handling. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Changes
Summary by CodeRabbit