Skip to content

Coordinate multi-repo issues better #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mulkieran opened this issue Feb 25, 2025 · 4 comments
Open

Coordinate multi-repo issues better #755

mulkieran opened this issue Feb 25, 2025 · 4 comments
Assignees

Comments

@mulkieran
Copy link
Member

mulkieran commented Feb 25, 2025

Sometimes we have to manually coordinate PRs in several repos to address one new feature.

We would like to set up GitHub Workflows so that this can be handled automatically if we can agree on a standard naming scheme for the issues.

New features usually break stratisd CI on the stratis-cli tests and the testing tests. It would be nice if the CI would automatically look for the correct repo and the correctly named branch or PR and just use that to run the test.

@mulkieran
Copy link
Member Author

Our current challenge example is issue-stratisd-3805. What should be the name of the passing stratis-cli PR? Actually giving it the exact same name could be reasonable.

@mulkieran
Copy link
Member Author

mulkieran commented Apr 8, 2025

The biggest technical difficulty is mapping from a name to a ref spec that can be used to specify the PR. I don't believe there is an available GitHub Action to do that. So, we would have to do that calculation ourselves. And now, we're into writing our own GitHub Action territory. The difficulty is that, through git actions we can actually obtain the prs, by number. But we need to use the GitHub API or gh to get the name of the PR from the number in order to determine what number we want to use as a ref.

@mulkieran mulkieran self-assigned this Apr 8, 2025
@mulkieran
Copy link
Member Author

I filed an issue with the checkout action upstream as I believe that I have found a bug: actions/checkout#2140 .

Assuming I'm correct, once that bug is fixed it will be easy to specify the interesting PR via simply changing the ref spec to the one from the appropriate PR.

We will still have not solved the name to PR id mapping problem, but we will be closer.

@github-project-automation github-project-automation bot moved this to Todo in 2025April Apr 9, 2025
@mulkieran mulkieran moved this from Todo to In Progress (long term) in 2025April Apr 9, 2025
@mulkieran
Copy link
Member Author

I figured out the refspec that would work as noted in actions/checkout#2140 . So, now we just need to persuade checkout to handle the PR id mapping problem.

@mulkieran mulkieran added this to 2025May May 4, 2025
@mulkieran mulkieran removed this from 2025April May 4, 2025
@github-project-automation github-project-automation bot moved this to Todo in 2025May May 4, 2025
@mulkieran mulkieran moved this from Todo to In Progress (long term) in 2025May May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress (long term)
Development

No branches or pull requests

1 participant