Skip to content

fix: use gen_rpc on MetricsController #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 26, 2025
Merged

fix: use gen_rpc on MetricsController #1437

merged 4 commits into from
Jun 26, 2025

Conversation

edgurgel
Copy link
Member

@edgurgel edgurgel commented Jun 26, 2025

What kind of change does this PR introduce?

Update MetricsController to use gen_rpc

Also expose two configurations for gen_rpc send and connect timeout.

What is the current behavior?

Using good old rpc

What is the new behavior?

Use the new shiny gen_rpc

Additional context

Add any other context or screenshots.

Copy link

vercel bot commented Jun 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
realtime-demo ⬜️ Ignored (Inspect) Jun 26, 2025 6:14am

@coveralls
Copy link

coveralls commented Jun 26, 2025

Coverage Status

coverage: 84.769% (+0.1%) from 84.636%
when pulling bfc77d1 on fix/more-gen_rpc
into 1acd42d on main.

@edgurgel edgurgel merged commit f2bef31 into main Jun 26, 2025
7 of 8 checks passed
@edgurgel edgurgel deleted the fix/more-gen_rpc branch June 26, 2025 08:27
@kiwicopple
Copy link
Member

🎉 This PR is included in version 2.37.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants