Skip to content

LCDC should be initialised with BG on #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tkers opened this issue Mar 14, 2022 · 3 comments · Fixed by #354
Closed

LCDC should be initialised with BG on #353

tkers opened this issue Mar 14, 2022 · 3 comments · Fixed by #354
Assignees
Labels
bug Something isn't working

Comments

@tkers
Copy link
Contributor

tkers commented Mar 14, 2022

I noticed that the LCDC register (0xFF40) is initialised to 1001 0000, which means the background (bit 0) is not enabled by default.

It is my understanding that the correct value on startup should be 1001 0001 instead. At least, when testing on a physical device (and a bunch of emulators), background rendering has always worked for me without touching the LCDC register.

@torch2424 torch2424 self-assigned this Mar 15, 2022
@torch2424 torch2424 added the bug Something isn't working label Mar 15, 2022
@torch2424
Copy link
Owner

Yoooo! Thank you so much for finding and reporting this! 😄 I haven't had much time to work on the emulator as of late, but that's a super simple fix, so maybe after my next concert I'm doing, I'll go ahead and open a PR for that real quick! 😄 Thank you! 🙏🏾

@tkers
Copy link
Contributor Author

tkers commented Mar 24, 2022

I actually didn't realise you hadn't worked on this emulator for a while when I opened this issue 😄 Anyway, I had some time and managed to find where the initialisation happens and created a PR for this ☝️

@torch2424
Copy link
Owner

This should be published in 0.7.1 😄 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants