DATA 4228: Update SDKs and CLI #934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabegottlob
approved these changes
Jun 13, 2025
tests/test_data_pipelines.py
Outdated
| @@ -15,6 +16,7 @@ | |||
| SCHEDULE = "0 0 * * *" | |||
| UPDATED_SCHEDULE = "0 1 * * *" | |||
| MQL_BINARY = [] | |||
| DATA_SOURCE_TYPE = TabularDataSourceType.TABULAR_DATA_SOURCE_TYPE_STANDARD | |||
There was a problem hiding this comment.
(nit) but @stuqdog told me that since the default data source type is standard we could in theory have a case where this is not transmitting correctly but the test still passes because it still gets standard back. Could you maybe use a non-standard type in the test? no need to re request review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating python sdk to include dataSourceType in CREATE functionality.
Updated tests to match this change and all tests are passing.