refactor[venom]: refactor ir_node_to_venom #4684
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
explicit Label/PUSHLABEL instructions.
runtime source map now only appears in source_map_runtime, not source_map.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| def __init__(self, item: bytes | Label): | ||
| self.data = item | ||
|
|
||
| def __repr__(self): |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note
| # at _sym_revert0 to: INVALID | ||
| return [_revert_label, "JUMPI"] | ||
| # a string (assembly instruction) but with additional metadata from the source code | ||
| class TaggedInstruction(str): |
Check warning
Code scanning / CodeQL
`__eq__` not overridden when adding attributes Warning
| def _convert_ir_list(self, ir_list: Iterable[IRnode]): | ||
| return [self.convert_ir(ir_node) for ir_node in ir_list] | ||
|
|
||
| def _convert_ir(self, ir: IRnode): |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note
| new_fn = self._handle_internal_func(ir, does_return_data) | ||
| with self.anchor_fn(new_fn): | ||
| for ir_node in ir.args[1:]: | ||
| ret = self.convert_ir(ir_node) |
Check notice
Code scanning / CodeQL
Unused local variable Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
remove globals, make a builder/lowerer object so that we can build venom incrementally too
continues off of #4663 since there would be merge conflicts otherwise.
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture