Skip to content

refactor[tool]: relax output bundle construction #4706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

charles-cooper
Copy link
Member

this always produces a valid input bundle. it doesn't guarantee that paths are always anonymized, but it guarantees that the output bundle is produced, rather than panicking (which is rather frustrating UX).

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

this always produces a valid input bundle. it doesn't guarantee that
paths are always anonymized, but it guarantees that the output bundle is
produced, rather than panicking (which is rather frustrating UX).
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.98%. Comparing base (c1b6130) to head (85d87a6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
vyper/compiler/output_bundle.py 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4706      +/-   ##
==========================================
- Coverage   92.99%   92.98%   -0.01%     
==========================================
  Files         131      131              
  Lines       19094    19096       +2     
  Branches     3324     3325       +1     
==========================================
  Hits        17757    17757              
- Misses        899      900       +1     
- Partials      438      439       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charles-cooper charles-cooper marked this pull request as ready for review June 26, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant