Skip to content

docs(cloudflare): custom entryfile #11743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 19, 2025
Merged

Conversation

alexanderniebuhr
Copy link
Member

@alexanderniebuhr alexanderniebuhr commented May 22, 2025

docs for withastro/astro#13837

I'm not sure if we should a full section which explain the usage of this a bit more, or if it is enough to document the new options like I did? Also maybe the two options should be nested under one common prefix entryfile.path & entryfile.exports, however not to sure 🤔

Copy link

netlify bot commented May 22, 2025

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit ae11c10
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/6853d1c2ed2e5d0008c0cb54
😎 Deploy Preview https://deploy-preview-11743--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented May 22, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/integrations-guide/cloudflare.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918
Copy link
Member

Quick note @alexanderniebuhr that I was waiting on this one since there seemed to be a flurry of activity on the Astro PR, and I wanted to make sure everything shook out there first!

Is the content here still consistent with that PR? And, I know that a changeset is needed on the other PR. Please make sure to loop me in on THAT PR so I can look at the changeset, too! 💜

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels May 26, 2025
@alexanderniebuhr
Copy link
Member Author

It's still in sync, but I will update it and ping you.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alexanderniebuhr This looks great! I think you've followed the existing models really well! 🙌

I left some tiny suggestions, plus since these things are new, they will need the <Since> component as well to say in which exact version they appeared in. (Usually this is a minor version as that's normally when new features are added, but I don't yet see a changeset for me to be able to confirm that.)

Tag me on the implementation PR when there's a changeset to review, and we'll make sure that matches what's here! 💜

@alexanderniebuhr alexanderniebuhr force-pushed the cloudflare-custom-entryfile branch from 8d96b18 to 42e81bd Compare June 7, 2025 08:47
@alexanderniebuhr
Copy link
Member Author

cc @sarah11918 I've updated this due to changes in the core PR. Also add some comments.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this, @alexanderniebuhr ! I really appreciate the attention you give to your docs, and you provide super helpful content!

See my (big) suggestion below that I think simply restructures/formats this to support your helpful content even more by making it scannable, look-up-able, and linkable. (And of course, needs your help to make sure it's all accurate and comprehensive!) 🙌

alexanderniebuhr and others added 3 commits June 10, 2025 07:20
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
alexanderniebuhr and others added 3 commits June 11, 2025 07:26
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one point of confusion, but otherwise, this will be good to go! Thank you @alexanderniebuhr

Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, this is great, Alex! Thanks for your patience, and this is approved for merging with the feature release! 🥳

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit. As a bit of a follow-up, I feel like what people will look for is "how to use queues/durable objects/etc with Astro Cloudflare, so we might want to add a heading in the future that points to this part, but surely not the scope of this PR.

@ascorbic ascorbic added this to the 5.10.0 milestone Jun 19, 2025
alexanderniebuhr and others added 3 commits June 19, 2025 11:00
Co-authored-by: Matt Kane <m@mk.gg>
Co-authored-by: Matt Kane <m@mk.gg>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
@sarah11918 sarah11918 changed the base branch from main to 5.10.0 June 19, 2025 10:50
@sarah11918 sarah11918 merged commit bd72f21 into 5.10.0 Jun 19, 2025
10 checks passed
@sarah11918 sarah11918 deleted the cloudflare-custom-entryfile branch June 19, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants