-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
docs(cloudflare): custom entryfile #11743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Quick note @alexanderniebuhr that I was waiting on this one since there seemed to be a flurry of activity on the Astro PR, and I wanted to make sure everything shook out there first! Is the content here still consistent with that PR? And, I know that a changeset is needed on the other PR. Please make sure to loop me in on THAT PR so I can look at the changeset, too! 💜 |
It's still in sync, but I will update it and ping you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @alexanderniebuhr This looks great! I think you've followed the existing models really well! 🙌
I left some tiny suggestions, plus since these things are new, they will need the <Since>
component as well to say in which exact version they appeared in. (Usually this is a minor version as that's normally when new features are added, but I don't yet see a changeset for me to be able to confirm that.)
Tag me on the implementation PR when there's a changeset to review, and we'll make sure that matches what's here! 💜
8d96b18
to
42e81bd
Compare
cc @sarah11918 I've updated this due to changes in the core PR. Also add some comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this, @alexanderniebuhr ! I really appreciate the attention you give to your docs, and you provide super helpful content!
See my (big) suggestion below that I think simply restructures/formats this to support your helpful content even more by making it scannable, look-up-able, and linkable. (And of course, needs your help to make sure it's all accurate and comprehensive!) 🙌
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one point of confusion, but otherwise, this will be good to go! Thank you @alexanderniebuhr
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, this is great, Alex! Thanks for your patience, and this is approved for merging with the feature release! 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small nit. As a bit of a follow-up, I feel like what people will look for is "how to use queues/durable objects/etc with Astro Cloudflare, so we might want to add a heading in the future that points to this part, but surely not the scope of this PR.
Co-authored-by: Matt Kane <m@mk.gg>
Co-authored-by: Matt Kane <m@mk.gg>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
docs for withastro/astro#13837
I'm not sure if we should a full section which explain the usage of this a bit more, or if it is enough to document the new options like I did? Also maybe the two options should be nested under one common prefix
entryfile.path
&entryfile.exports
, however not to sure 🤔