-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Clarify GitHub Pages base
config and withastro/action
usage
#11753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Hi @casungo ! Sorry this PR hasn't had much activity on it! I was hoping someone would be available to help go through this! Firstly, there are conflicts to resolve. Would you mind handling those? Secondly, the linked issue mentions that this did not fix someone's problem, but linked to a blog post showing adding a Since I haven't had a chance to carefully go through this, I do want to first only update what is incorrect so that these instructions lead to success for someone. (Vs changing explanations / descriptions because they might be "better"). It is much easier to review a PR that only includes corrections for things that are wrong than one that also tries to improve it in various ways. And, since we're struggling to keep up with PRs right now, we need all the help we can get! 😅 So, can we make sure this PR is only about correcting wrong or missing info, so that we can this reviewed and merged more quickly? For example, this PR changes statements that are correct like:
to maybe "better" instructions like:
but these don't fix a problem with incorrect statements at this time. I don't disagree that your statement is better! But, there are many of these "upgrades" that don't fix a problem, and that makes it harder to spot the things that actually are incorrect, and make this PR take longer to review. 😅 Right now, we really need to optimize for correcting inaccuracies! Would you be willing to rework this PR in the above ways? (Resolve conflicts, figure out how to helpfully add the |
Description
This PR updates the English documentation for deploying Astro sites to GitHub Pages (
guides/deploy/github.mdx
) to address several points of confusion and provide clearer, more accurate instructions.These changes aim to significantly reduce confusion for users deploying to GitHub Pages subpaths and improve the reliability of their setups by promoting best practices for path handling.
Related issues & labels
github.mdx
: The description of the text is discrepancy. #10868improve or update documentation