-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: document experimental static headers #11971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this probably needs correcting, but I tried to make this sound first, a bit generic, and then, use CSP as an example of when/how it's used. Lists with one item always feel weird, so maybe we can get around that! 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed two typo, and I wonder if experimentalStaticHeaders
is in the right place for the Netlify adapter.
We are not excluding/including files but setting custom CSP directives per page, right? So, we could use an h3
instead of an h4
but then, this heading could be inconsistent with others under Usage
. Should we have something like the following?
## Usage
...
### Custom headers for prerendered pages
Some intro?
#### `experimentalStaticHeaders`
The current content.
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you @ematipico ! This will be good to merge tomorrow!
@sarah11918 and @ArmandPhilippot The commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a missing p
tag, otherwise LGTM!
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Description (required)
This PR adds documentation of
experimentalStaticHeaders
for the Node.js adapter and Netlify adpater.For Astro version:
5.11
. See astro PR #13972.