fix memory leaks #178
Open
fix memory leaks #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannickl
reviewed
Oct 6, 2019
Comment on lines
+204
to
205
| guard let self = self else { return } | ||
| guard !self.session.isRunning else { return } |
There was a problem hiding this comment.
I prefer one line guard. Is it possible to inline the first statement?
guard let self = self, !self.session.isRunning else { return }
Comment on lines
+218
to
219
| guard let self = self else { return } | ||
| guard self.session.isRunning else { return } |
There was a problem hiding this comment.
The same here.
guard let self = self, self.session.isRunning else { return }
|
@yannickl May I ask you to merge the changes and apply the two changes afterwards? The memory issue is quite severe. Thank you! |
pull from upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.