missing workspace emojis

[Ants-Aare]

Captchas

• I have read the instructions.
• I have searched existing issues and avoided creating duplicates.
• I am not filing an enhancement request.
• I have checked that this issue cannot be reproduced on Mozilla Firefox.
• I have checked that this issue can be reproduced once I removed all my Mods and Custom CSS.

What happened?

When adding a new workspace and searching for emojis, even using their unicode character, some emojis don't show up. 🧬🧪🥼🕵️‍♂️ are just some of the missing emojis. Why isn't the entire default OS emoji set showing for me? It's not even like a whole category is missing, something strange must be going on.

Version

1.11.1b

What platform are you seeing the problem on?

macOS - aarch64

What component is this issue related to?

Workspaces

Relevant log output if applicable

[parkeraddison]

There have been a couple PRs in the past to add single emojis:

• Add Bat to ZenEmojies #4734
• Feature: add martial arts uniform emoji #6021

I don't know if there's any good examples for how to contribute new emoji support. But release 1.9b included a new emoji in the release notes:

• Added martial arts emoji to the default emoji set

Looks like everything is stored in https://github.com/zen-browser/desktop/blob/dev/src/zen/common/ZenEmojies.mjs

The contribution at #4734 was no good, it broke search functionality, since it added in the wrong format:

['🦇','bat']

whereas #6021 is proper format. Looks like we need the emoji, official name, and then a comma-separated list (which must contain a comma) of search keywords:

['🥋', 'martial_arts_uniform', 'martial arts, judo']

So some current working examples (note how the first one has a comma in the search term even though there's only one element):

['🔔','bell',', bell']
['🐍','snake','animal, snake']
['🏢','office','office building, work, building, office']

My question -- isn't there some exhaustive list of all of the names and search terms already out there? Why are we adding things one-by-one?

Maybe we can find this and make a quick PR to fix.

[parkeraddison]

I wonder if we should rely on something like https://github.com/nolanlawson/emoji-picker-element (if Zen isn't already)?

It's currently not possible to trigger the OS native emoji picker (no API for the browser to use), but as it stands the current implementation feels like it's lacking a few things like number of emojis and internationalization.

Otherwise, the full list of the Unicode Common Locale Data Repository (CLDR) emoji search keywords can be found here, including for other languages: https://github.com/unicode-org/cldr-json/blob/main/cldr-json/cldr-annotations-full/annotations/en/annotations.json

For example, the full list of English search keywords for the martial arts emoji we saw above should be:

      "🥋": {
        "default": [
          "arts",
          "judo",
          "karate",
          "martial",
          "taekwondo",
          "uniform"
        ],
        "tts": [
          "martial arts uniform"
        ]
      },

(source: https://github.com/unicode-org/cldr-json/blob/effc2b88b756dc1eedff0fa5bfc22f708a2457e5/cldr-json/cldr-annotations-full/annotations/en/annotations.json#L18172-L18184)

Interested in hearing thoughts

[dosubot]

Hi, @Ants-Aare. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.

Issue Summary:

• You reported missing emojis when adding a new workspace on macOS using version 1.11.1b.
• The issue does not occur on Mozilla Firefox.
• Parkeraddison provided insights into past pull requests related to emoji additions.
• Suggestions were made to use external resources like Unicode CLDR for a comprehensive emoji list.
• Consideration was proposed for integrating an emoji picker element to enhance functionality.

Next Steps:

• Please let us know if this issue is still relevant to the latest version of the desktop repository by commenting here.
• If there is no further activity, this issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

[parkeraddison]

@dosubot This is still relevant to the latest version.

[mr-cheffy]

It's currently not possible to trigger the OS native emoji picker (no API for the browser to use)

Mainly because linux doesn't have one iirc. Ill take a look for https://github.com/nolanlawson/emoji-picker-element